netlify / build-image

This is the build image used for running automated builds
MIT License
497 stars 196 forks source link

chore: build image for multiple CPU architectures linux/amd64,linux/arm64 #828

Closed lukasholzer closed 2 years ago

lukasholzer commented 2 years ago

๐ŸŽ‰ Thanks for submitting a pull request! ๐ŸŽ‰

Summary

Fixes #822 Fixes #821


For us to review and ship your PR efficiently, please perform the following steps:

A picture of a cute animal (not mandatory, but encouraged) image

lukasholzer commented 2 years ago

Currently blocked by https://github.com/netlify/binrc/issues/36

lukasholzer commented 2 years ago

Forked PR's

the onhold works fine

CleanShot 2022-08-19 at 11 40 15@2x CleanShot 2022-08-19 at 13 45 42@2x

The image on hub.docker.com

CleanShot 2022-08-19 at 13 49 23@2x
lukasholzer commented 2 years ago

The overall pipeline time went down from 20min to 14min by removing the need of saving and attaching the images and doing the testing and building in one stage

CleanShot 2022-08-19 at 14 57 39

lukasholzer commented 2 years ago

working for tags as well:

CleanShot 2022-08-26 at 11 53 54

https://hub.docker.com/layers/build/netlify/build/v4.10.1-test.7-squash/images/sha256-abfb143ef652cd3bfd6aef99dca7607bd83bab02352e83268d0e0a8ab52ca2d1?context=explore

lukasholzer commented 2 years ago

@kitop can you try running make build-base on your local mac? I guess you have a intel one or?

kitop commented 2 years ago

@kitop can you try running make build-base on your local mac? I guess you have a intel one or?

@lukasholzer it seemed to work, took 815.1s. Do you want me to run anything else in particular? tests? a script?

lukasholzer commented 2 years ago

@kitop can you try running make build-base on your local mac? I guess you have a intel one or?

@lukasholzer it seemed to work, took 815.1s. Do you want me to run anything else in particular? tests? a script?

nope just wanted to check if the local commands are working with make (gathering the correct archname on amd machines) Tests and everything are working on the CI so should be more than good to go