search

netlify / build-image

This is the build image used for running automated builds
MIT License
496 stars 197 forks source link

feat: package manager detection for mono repositories #858

Closed lukasholzer closed 1 year ago

lukasholzer commented 1 year ago

🎉 Thanks for submitting a pull request! 🎉

Summary

Part of https://github.com/netlify/pillar-workflow/issues/895

Needs: https://github.com/netlify/build-image/pull/866

Waiting for: https://github.com/netlify/buildbot/pull/2318/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

For us to review and ship your PR efficiently, please perform the following steps:

A picture of a cute animal (not mandatory, but encouraged)

jobala commented 1 year ago

This looks good @lukasholzer. I really like the package manager detection and can't wait for the deprecation of NETLIFYUSE* env variables. Do you plan on adding tests for workspace & package manager detection?

lukasholzer commented 1 year ago

This looks good @lukasholzer. I really like the package manager detection and can't wait for the deprecation of NETLIFYUSE* env variables. Do you plan on adding tests for workspace & package manager detection?

The detection mechanism is already tested inside @netlify/build-info

lukasholzer commented 1 year ago

This change will be rolled out with a feature flag first only to our internal sites and all @netlify.com users after the low risk week we will extend this then to other users as well.

lukasholzer commented 1 year ago

Need to align this with https://github.com/netlify/buildbot/pull/2318 as it introduces a breaking change to the order of the arguments in run-build-functions.sh