netlify / build-image

This is the build image used for running automated builds
MIT License
496 stars 197 forks source link

feat: Custom composer options with the `COMPOSER_FLAGS` environment variable #865

Open aguingand opened 1 year ago

aguingand commented 1 year ago

Summary

Related to #237

Deploy command generally doesn't need composer's "require-dev" dependencies. We can prevent installing these packages by adding the --no-dev option to composer install. This PR allows to add composer options in the following environment variable:

COMPOSER_FLAGS = "--no-dev"

There are other install options that may be useful depending on projects.


For us to review and ship your PR efficiently, please perform the following steps:

A picture of a cute animal (not mandatory, but encouraged)

image

conventional-commit-lint-gcf[bot] commented 1 year ago

πŸ€– I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

kitop commented 1 year ago

Thanks for the contribution, @aguingand Do you mind adding a test for this?

aguingand commented 1 year ago

@kitop done !