fix: framework detection for solidjs and solidstart

netlify / build

Netlify Build (node process) runs the build command, Build Plugins and bundles Netlify Functions. Can be run in Buildbot or locally using Netlify CLI

https://docs.netlify.com/configure-builds/build-plugins/

MIT License

217 stars 55 forks source link

fix: framework detection for solidjs and solidstart #5856

Closed orinokai closed 5 hours ago

orinokai commented 5 days ago

Summary

Updating framework detection for Solid and SolidStart. The latter is now published as @solidjs/start and uses Vinxi. I've taken the opportunity to update the publish dir to dist, since this is Vite under the hood. We should contact Ryan after this goes live because he can then remove a step from the docs.

serhalp commented 6 hours ago

@orinokai I pushed a commit that

reintroduces support for old SolidStart sites
adds Solid.js and SolidStart detection tests
makes the filename for Solid.js match the framework id like all the others
avoid the bug with using just vite as a dev command (I should really write up that bug... sorry)

sonarcloud[bot] commented 5 hours ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
31.7% Duplication on New Code

See analysis details on SonarCloud