netlify / cli

Netlify Command Line Interface
http://cli.netlify.com
MIT License
1.58k stars 359 forks source link

fix: check ip version if settings.useStaticServer #6936

Open khendrikse opened 19 hours ago

khendrikse commented 19 hours ago

๐ŸŽ‰ Thanks for submitting a pull request! ๐ŸŽ‰

Summary

This hopefully fixes this: https://answers.netlify.com/t/128792

I noticed, while running this on windows in a VM, that the proxy was trying to connect to an IPv4 server, while the static server was actually an IPv6 one.

With this logic, we explicitly check what version we are running within the settings.useStaticServer branch of logic as well.


For us to review and ship your PR efficiently, please perform the following steps:

A picture of a cute animal (not mandatory, but encouraged)

khendrikse commented 17 hours ago

Were you able to see the failure in the CI? Any chance we could add a test to verify it's fixed?

No we didn't see it, but I'm going to try out running tests on win + node 23 in the pipelines. Wish me luck lol.