search

netlify / explorers

https://explorers.netlify.com/
MIT License
261 stars 40 forks source link

fix (#379): track whether confetti has been fired before locally #386

Closed bencodezen closed 4 years ago

bencodezen commented 4 years ago

This does not completely solve #379, but is a good iteration as far as at least defining a local variable that should prevent it from recurring otherwise.

We still need something to figure out why it's maintaining the same stage even though it's a new URL. My guess is Next.js is doing some sort of keep-alive with the [stage].js page and highjacking the navigation so I can't listen to unload or some kind of unmount.

tzmanics commented 4 years ago

This iteration is great!! Thanks, Ben!

bencodezen commented 4 years ago

@tzmanics I've added the closeModal to the embark button so we should be good for this iteration now