netlify / framework-info

Framework detection utility
MIT License
137 stars 21 forks source link

Add Remix detection #657

Closed erezrokah closed 2 years ago

erezrokah commented 2 years ago

Which problem is this feature request solving?

Add support for detecting the Remix framework.

Describe the solution you'd like

Add a Remix configuration file to https://github.com/netlify/framework-info/tree/main/src/frameworks

Describe alternatives you've considered

Having users manually configure Remix

Other Context

This will probably be a breaking change for this library, as we'll make dev.port and dev.commands optional: https://github.com/netlify/framework-info/blob/6641697d1c2770cc7dec025864216176c1cc4bb5/test/frameworks.js#L89

Based on https://github.com/netlify/cli/issues/3654#issuecomment-972759281 Related to https://github.com/netlify/cli/issues/3655

erezrokah commented 2 years ago

Done in https://github.com/netlify/framework-info/pull/658