search

netlify / framework-info

Framework detection utility
MIT License
137 stars 21 forks source link

Cypress tests on Firefox are failing #714

Open ehmicky opened 2 years ago

ehmicky commented 2 years ago

Cypress tests on Firefox are currently failing. The following PR is skipping them, but we should re-enable them: https://github.com/netlify/framework-info/pull/715

They started failing with the following PR: https://github.com/netlify/framework-info/pull/691. The problem seems to be related to using dependencies using pure ES modules, not to p-filter. I based this statement from some debugging where I tried to upgrade p-locate first instead (https://github.com/netlify/framework-info/pull/692), and the result was the same.

Also, this appears to be a problem only with our tests. In production, Firefox works well with framework-info.

Finally, this is not a problem with using pure ES modules in framework-info itself, since we migrated to ES modules before upgrading p-filter and the tests on Firefox were successful.