Closed nickytonline closed 2 years ago
Which problem is this feature request solving?
We currently detect Solid Start, but not Solid JS
Describe the solution you'd like
Currently we only have a configuration for Solid Start. See https://github.com/netlify/framework-info/blob/main/src/frameworks/solid-start.json.
We'd need to add a solid-js.json configuration for SolidJS.
We’d need to do is look for the solid-js npm dependency and have solid-start in the excluded npm dependencies for a “vanilla” SolidJS app.
the solid-js
solid-start
e.g.
{ "id": "solid-js", "name": "SolidJS", "category": "static_site_generator", "detect": { "npmDependencies": ["solid-js"], "excludedNpmDependencies": ["solid-start"], "configFiles": [] }, "dev": { "command": "nom run dev", "port": 3000, "pollingStrategies": [{ "name": "TCP" }] }, "build": { "command": "npm run build", "directory": "netlify" }, "logo": { "default": "/logos/solid-js/default.svg", "light": "/logos/solid-js/default.svg", "dark": "/logos/solid-js/default.svg" }, "env": {}, "plugins": [] }
We'd also need SolidJS logos.
And we’d need to exclude the solid-js dependency from the vite framework info.
Describe alternatives you've considered
N/A
Can you submit a pull request?
Yes
Which problem is this feature request solving?
We currently detect Solid Start, but not Solid JS
Describe the solution you'd like
Currently we only have a configuration for Solid Start. See https://github.com/netlify/framework-info/blob/main/src/frameworks/solid-start.json.
We'd need to add a solid-js.json configuration for SolidJS.
We’d need to do is look for
the solid-js
npm dependency and havesolid-start
in the excluded npm dependencies for a “vanilla” SolidJS app.e.g.
We'd also need SolidJS logos.
And we’d need to exclude the solid-js dependency from the vite framework info.
Describe alternatives you've considered
N/A
Can you submit a pull request?
Yes