search

netlify / framework-info

Framework detection utility
MIT License
137 stars 21 forks source link

fix: handle version for frameworks which are not detected by npm package #842

Closed danez closed 1 year ago

danez commented 1 year ago

Summary

This handles frameworks that are not detected by npm package correctly. When the framework info has no package name we simply do not attempt to detect the version.

On the way I also fixed some types, changed from chdir() to use the cwd option of find-up and added code that handles rejected promises from Promise.allSettled to not swallow errors as we do right now.

Fixes netlify/cli#5221

netlify[bot] commented 1 year ago

Deploy Preview for framework-info ready!

Name Link
Latest commit ede18309fcc0750da8aa74063e25904cc9853f44
Latest deploy log https://app.netlify.com/sites/framework-info/deploys/637ba3d71b78220008b8a9a2
Deploy Preview https://deploy-preview-842--framework-info.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

SteveALee commented 1 year ago

Thank you. How can we tell when this lands in a published version of the CLI?