Closed Benaiah closed 6 years ago
also if you want to update the Go version, it might be worth it right now.
It looks like this requires a docs update. At this point, I think that means some minor changes to the README and an update to example.env
@rybit @calavera addressed your review comments - could you re-review? @rybit upgrading Go sounds great, but I'm not sure I know the whole process for doing so for this repo.
Fixes several bugs with GitLab support in git-gateway:
HEAD
requests to the allowed CORS methods."Private-Token"
to the allowed CORS headers.r.URL.Opaque
instead of by settingr.URL.Path
to prevent literal%2F
s in URLs, which are required by the GitLab API, from being turned into literal/
characters by the Go stdlib. (see this github issue and this commit, noting thatgit-gateway
is running ongo1.8
if I understand correctly from the.travis.yml
).Authorization
header from GitLab requests, which causes 401s when used with private access tokens (example), and replaces it with thePrivate-Token
header. (The current WIP Netlify UI has a box for a token to be pasted, so I assume this is supposed to be a private access token, not an OAuth token - which would use theAuthorization
header).Link
header to be relative, so they're requested from git-gateway instead of the proxied API.