netlify / git-gateway

A Gateway to Git APIs
MIT License
400 stars 89 forks source link

The existing tag uses a too old version of Go #26

Closed edevil closed 5 years ago

edevil commented 5 years ago

The current tag used of the FROM image, v0.12.3, uses a too old version of Go (1.8). This prevents a successful build of the image:

Step 3/5 : RUN useradd -m netlify && cd /go/src/github.com/netlify/git-gateway && make deps build && mv git-gateway /usr/local/bin/
 ---> Running in a9f3d45da33f
# golang.org/x/tools/go/internal/gcimporter
/go/src/golang.org/x/tools/go/internal/gcimporter/bexport.go:212: obj.IsAlias undefined (type *types.TypeName has no field or method IsAlias)
Makefile:13: recipe for target 'deps' failed
make: *** [deps] Error 2
The command '/bin/sh -c useradd -m netlify && cd /go/src/github.com/netlify/git-gateway && make deps build && mv git-gateway /usr/local/bin/' returned a non-zero code: 2

There is a new version of the netlify/go-glide image pushed, unfortunately it does not have a tag assigned, so we need to rely on the "latest" tag...

- A picture of a cute animal (not mandatory but encouraged)

              ,       ,
             ( \     / (
             \  '---'  /
             /.--. .--,\   .-'''-,
            /\_(o) (o)_/\ /\ | /  \
        __.-.___(_c_)_.-./\ \ / / /)
       (__(((_________)))__--''/ / /
        |  ||  ||  ||  ||  ||   / )
        |  ||  ||  ||  ||  ||   |/
        |  ||  ||  ||  ||  ||   '
        \  ||  ||  ||  ||  ||
         \ ||  ||  ||  |.- -'''- -._
         /\||  ||  ||  ;            :
        |  ||  ||  || :      __      ;
        |  ||  ||  ||:      (  (      :
        |  ||  ||  ||;               .
        |  ||  ||  || ,             , 
        .,_c,__.,__ldb__'- -,..,- -'
shawnmmatthews commented 5 years ago

I ran into this same issue. Updating the tag fixed it. Thanks!!