search

netlify / git-gateway

A Gateway to Git APIs
MIT License
404 stars 89 forks source link

GitLab support #9

Closed jayvdb closed 5 years ago

jayvdb commented 7 years ago

Does this support GitLab? Is that on the horizon?

biilmann commented 6 years ago

We would love to support GitLab and it should be fairly straight forward - main difference from the GitHub integration would be having to handle refresh tokens rather than just plain access tokens

tech4him1 commented 6 years ago

@biilmann I've been testing GitLab's OAuth (standard Web Application Flow), and even though it sends a refresh token along with the access token, the access token doesn't seem to expire. I'm not sure whether this is a setting that could be changed, but for now it seems that we don't need to worry about refresh tokens. Is your experience different there?

erquhart commented 6 years ago

The example response shows an expiry field - we'll probably want to provide for the expiration case even if the timing isn't clear cut.

kobvel commented 6 years ago

Any progress on this one?

timaschew commented 5 years ago

I'm confused.

If you check the current Readme it seems that GitLab works.

Netlify’s Git Gateway lets you setup a gateway to your choice of Git provider's API ( now available with both GitHub and GitLab 🎉 ) that lets tools like Netlify CMS work with content, branches and pull requests on your users’ behalf.

So why this issues is not closed yet?
Also this one: https://github.com/netlify/netlify-cms/issues/568

// edit okay the last link is about editorial workflow, so it's not related to this issue directly.

tech4him1 commented 5 years ago

@timaschew You are correct, this issue should have been closed by #10. The editorial workflow support is CMS specific, so that is a different issue.