search

netlify / gotrue

An SWT based API for managing users and issuing SWT tokens.
https://www.gotrueapi.org
MIT License
3.88k stars 288 forks source link

Replace package satori/go.uuid #178

Closed josselin-c closed 3 years ago

josselin-c commented 6 years ago

This issue has been opened automaticaly because we think you are using satori/uuid in your code. Unfortunately, satori/uuid has a critical defect where it doesn't generate random UUIDV4s satori/go.uuid#73 and should be replaced as the maintainer has been unresponsive for 5 months with the bug still open. Alternative packages you should consider: https://github.com/google/uuid https://github.com/pborman/uuid

k1ng440 commented 6 years ago

done at https://github.com/netlify/gotrue/pull/188

k1ng440 commented 6 years ago

Solved.

rybit commented 6 years ago

So this isn't actually solved. The package (https://github.com/gobuffalo/uuid) we moved to is a fork of the problematic package and archived.

image

ghost commented 5 years ago

https://github.com/gobuffalo/uuid has removed the .Equal function. I can't compile the current master source, because seems like all mentained uuid versions are incompatible. Or which are you using?

trestoa commented 5 years ago

According to https://github.com/satori/go.uuid/issues/90#issuecomment-447887426, https://github.com/gofrs/uuid is the permanent and maintained fork of the module. I was already able to build and run gotrue using this module. I will do some more testing and submit a PR if everything works correctly.

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had activity in 1 year. It will be closed in 7 days if no further activity occurs. Thanks!

github-actions[bot] commented 3 years ago

This issue was closed because it had no activity for over 1 year.