search

netlify / gotrue

An SWT based API for managing users and issuing SWT tokens.
https://www.gotrueapi.org
MIT License
3.84k stars 285 forks source link

Remove extra build step from dockerfile #219

Closed kitop closed 4 years ago

kitop commented 4 years ago

- Summary When trying to deploy a new version of gotrue with Marcus, we noticed the /health endpoint wasn't returning version data. After some digging Marcus found that we're doing double builds in the Docker image, one via make build and then a go build after that. The go build one doesn't havee the version info and is redundant given the step before it.

This change removes the go build step so we rely in the makefile one.

- Test plan Verify we get version information on /health endpoint.

- A picture of a cute animal (not mandatory but encouraged)

kitop commented 4 years ago

Confirmed in staging that it has the version now:

$ curl https://identity-staging.services.netlify.com/health
{"description":"GoTrue is a user registration and authentication API","name":"GoTrue","version":"6ec851ca4049990dd85f33397e42fea9c9317b99"}%