netlify / gotrue

An SWT based API for managing users and issuing SWT tokens.
https://www.gotrueapi.org
MIT License
3.88k stars 287 forks source link

feat: add microsoft provider #226

Closed JamieMagee closed 2 years ago

JamieMagee commented 4 years ago

- Summary

Fixes #216

NOTE: It's not possible to get an avatar URL, only the actual binary data for the avatar.

Useful documentation:

- Test plan

Still TODO. Not 100% sure how to test this, and would appreciate any input here

- Description for the changelog

Initial implementation of Microsoft identity provider

- A picture of a cute animal (not mandatory but encouraged)

JamieMagee commented 4 years ago

@kitop @mraerino Can I get this reviewed? Or if not you, who should I ping about this?

mraerino commented 4 years ago

hey, we don't have a lot of bandwidth on the team for this right now.

I noticed there are no tests. can you add some?

JamieMagee commented 3 years ago

@kitop @mraerino If I rebase this, do you have bandwidth to review it?

tlsimm commented 3 years ago

@kitop I see this is still requiring some approvals - is this something we want still want to support?

kitop commented 3 years ago

This will fall under @rjbeers team, so he should be weighing in.

tlsimm commented 3 years ago

Can this be closed out?

JamieMagee commented 2 years ago

Closing this out. If you want to add this functionality, backport it from the supabase port^1