search

netlify / gotrue

An SWT based API for managing users and issuing SWT tokens.
https://www.gotrueapi.org
MIT License
3.84k stars 285 forks source link

Hide smtp pass from instance config output #227

Closed mraerino closed 4 years ago

mraerino commented 4 years ago

- Summary

We do not want to show a once entered password when getting instance details.

- Test plan

- Description for the changelog

Hide SMTP password from instance return

- A picture of a cute animal (not mandatory but encouraged)

vbrown608 commented 4 years ago

This might be a naive question (I haven't looked at this project much yet), but won't other handlers still return a non-empty SMTP password, eg UpdateInstance? It could be called with empty params.BaseConfig.

mraerino commented 4 years ago

Those are really good points 😄 Fixed it.