search

netlify / gotrue

An SWT based API for managing users and issuing SWT tokens.
https://www.gotrueapi.org
MIT License
3.84k stars 285 forks source link

Docs: Fix logging env vars example #230

Closed leomp12 closed 4 years ago

leomp12 commented 4 years ago

Add GOTRUE_ prefix to prevent confusion, also add GOTRUE_LOG_FILE sample value.

Should also add GOTRUE_LOG_FILE to example.env?

- Summary

Minor doc fix because I've tried with LOG_FILE and it took me a few minutes to realize that the log was empty :disappointed: Then I tried with GOTRUE_LOG_FILE and it works :smile:

- Description for the changelog

docs(readme): fix logging env vars example

- A picture of a cute animal (not mandatory but encouraged)

12670095_951550701593485_936418740864488038_n

mraerino commented 4 years ago

actually, LOG_LEVEL without the prefix works fine. it's explicitly handled specially in the config

leomp12 commented 4 years ago

Hey @mraerino , but and LOG_FILE? I've tried without prefix with no success, and Imo it's confuse to use (and document) LOG_LEVEL without prefix and GOTRUE_LOG_FILE with prefix, not?

mraerino commented 4 years ago

no, LOG_FILE does not work without prefix

leomp12 commented 4 years ago

yup, and that's why I think current reference is a little bit confusing :stuck_out_tongue: