search

netlify / netlify-auth-providers

JS library to use Netlify's OAuth providers
23 stars 4 forks source link

Localhost subdomains #5

Open pomber opened 5 years ago

pomber commented 5 years ago

Hey, there's a special case where the auth is failing for me: using subdomains on localhost.
For example I use: http://gitlab.localhost:3000 in this PR.

There are a few places where you compare the location.hostname with "localhost", it fails when hostanme is something like foo.localhost. Maybe you can compare it with location.hostname.split('.').pop().

swyxio commented 5 years ago

hey pomber, this repo isnt actively maintained. if you wanna PR a fix, i'll merge and republish for you but not actively fixing beyond that

pomber commented 5 years ago

Thanks swyx, I think the real issue may be in https://api.netlify.com/auth/done. Is there another repo for that one?

swyxio commented 5 years ago

our open api is here https://open-api.netlify.com/#/default but i can't find /auth/done... i'm not an api expert tho. tagging @futuregerald just in case