feat: allow disabling trace logging, while keeping Datadog tracing enabled

netlify / netlify-commons

MIT License

10 stars 9 forks source link

feat: allow disabling trace logging, while keeping Datadog tracing enabled #346

Closed Skn0tt closed 2 years ago

Skn0tt commented 2 years ago

This PR extends the DisableTracing config property added in https://github.com/netlify/netlify-commons/pull/338 to add a more fine-granular DisableTraceLogging option.

This allows services like Ingesteer, which have lots of requests but don't really need all of them logged, to only enable Datadog tracing, but not log information about every single request to Humio.

Works towards https://github.com/netlify/ingesteer/issues/169.

Skn0tt commented 2 years ago

technically, it's public, in reality, it's used by nobody: https://cs.github.com/?q=owner%3Anetlify+TrackRequest&p=1&pt=3ef9cebfa2b06556f3d994c753e4f3781cc51ab41b7f91c3ee5be7937f355c30f345ec0f2cd12b90e3716c62eaca4e8341f081aecdd4f5b12163a2b19960f7ef20c448ebad0656537f074aca7c3fc2969f0f82ccc5eba852169382d7&scope=&scopeName=All+repos

happy to move to go-observability though, sounds good!