netlify / netlify-statuskit

Netlify StatusKit is a template to deploy your own Status pages on Netlify.
https://www.netlify.com/status-pages/
MIT License
239 stars 41 forks source link

Multiple Active Incidents #32

Open steveoh opened 7 years ago

steveoh commented 7 years ago

- Do you want to request a feature or report a bug? bug - What is the current behavior? duplication of ✅ Up and running - If the current behavior is a bug, please provide the steps to reproduce. Create multiple unresolved incidents - What is the expected behavior? Only the systems that are affected change and there is no duplication.

image

RealGrim commented 6 years ago

Hello This is happening because you have to indents active at once please disable one, because there are both degraded performance you can just set it so its active on 2 indents like: affectedsystems = ["API", "CDN"]

If you are still having problems please got to gitter and ask @verythorough!

You can now close this :)

dracos commented 6 years ago

The original issue is a real one. If you have two active incidents for different affected systems (say one is under maintenance, another is degraded performance), then everything gets duplicated in the summary at the top. This is due to the loop over the incidents in partials/systems.html printing a line for each incident for each system, whereas it presuambly needs to work out the 'most severe' of all the incidents applying to that system.

mariuspana commented 6 years ago

I can confirm this behaviour and that your PR indeed solves this issue