search

netlify / netlifyctl

MIT License
176 stars 34 forks source link

Bad paths for GitLab repos with `init` #120

Closed verythorough closed 6 years ago

verythorough commented 6 years ago

netlifyctl init (without --manual) fails for GitLab repos, whether cloned via https or ssh.

I'm testing with version 0.3.3, in Git Bash for Windows, as well as Ubuntu WSL on Windows.

Here's the response and netlifyctl-debug.log for an ssh-cloned repo:

$ git remote -v
origin  git@gitlab.com:verythorough/elm-practice.git (fetch)
origin  git@gitlab.com:verythorough/elm-practice.git (push)

$ netlifyctl init
gitlab.com username: verythorough
gitlab.com password:
There was an error running this command.
Debug log dumped to netlifyctl-debug.log
This log includes full recordings of HTTP requests with credentials, be careful if you share it

$ cat netlifyctl-debug.log
time="25 May 18 13:56 -0700" level=debug msg=PreRun arguments=[] command=init
time="25 May 18 13:56 -0700" level=debug msg="configure debug middleware"
time="25 May 18 13:56 -0700" level=debug msg="configure logging middleware"
time="25 May 18 13:56 -0700" level=debug msg="setup logger middleware: panic"
time="25 May 18 13:56 -0700" level=debug msg="configure auth middleware"
time="25 May 18 13:56 -0700" level=debug msg="setup credentials"
time="25 May 18 13:56 -0700" level=debug msg="configure client middleware"
time="25 May 18 13:56 -0700" level=debug msg="setup API endpoint" endpoint="https://api.netlify.com"
time="25 May 18 13:56 -0700" level=error msg="command failed" error="Post /verythorough/elm-practice/session: unsupported protocol scheme \"\""

In the last line, the path to the repo isn't absolute, which I'm guessing is the source of the unsupported protocol scheme error (though the lowercase Post could be weird, too). It also has /session tacked on at the end of the path, after the repo name.

Here's the response and netlifyctl-debug.log for an https-cloned repo:

$ git remote -v
origin  https://gitlab.com/verythorough/eye-chart.git (fetch)
origin  https://gitlab.com/verythorough/eye-chart.git (push)

$ netlifyctl init
gitlab.com username: verythorough
gitlab.com password:
There was an error running this command.
Debug log dumped to netlifyctl-debug.log
This log includes full recordings of HTTP requests with credentials, be careful if you share it

$ cat netlifyctl-debug.log
time="25 May 18 13:58 -0700" level=debug msg=PreRun arguments=[] command=init
time="25 May 18 13:58 -0700" level=debug msg="configure debug middleware"
time="25 May 18 13:58 -0700" level=debug msg="configure logging middleware"
time="25 May 18 13:58 -0700" level=debug msg="setup logger middleware: panic"
time="25 May 18 13:58 -0700" level=debug msg="configure auth middleware"
time="25 May 18 13:58 -0700" level=debug msg="setup credentials" 
time="25 May 18 13:58 -0700" level=debug msg="configure client middleware"
time="25 May 18 13:58 -0700" level=debug msg="setup API endpoint" endpoint="https://api.netlify.com"
time="25 May 18 13:58 -0700" level=error msg="command failed" error="POST https://gitlab.com/verythorough/eye-chart.git/session: 404 failed to parse unexpected error type: <nil>"

As you can see, this one also tacks on the /session bit at the end of the path, and who knows what error type: <nil> is! 😉

Hopefully that helps. As I work on docs, I'm going to say that for now, plain init works only with GitHub repos cloned via ssh (the ssh part due to #110), and suggest init --manual for other setups.