search

netlify / netlifyctl

MIT License
176 stars 34 forks source link

return some indication of whether the old deployment was locked when a new production deploy is sent #80

Closed fool closed 6 years ago

fool commented 6 years ago

This was a suggestion from a customer.

Scenario: You use locked deploys in the UI to prevent autopublishing from git. This works fine until you send a deploy via netlifyctl deploy which will publish the current deploy - and leave deploys UNLOCKED.

Suggestion: before deploying, check for the current deploy being locked and output some sort of warning that you've now turned off locking and should revisit the site dashboard to re-lock deploys.

calavera commented 6 years ago

I would consider this a bug in Netlify's API. No deploys should unlock a locked deploy regardless the deploying method, either cli or netlify's CD.

fool commented 6 years ago

Support totally agrees but you said the opposite a few months ago :) We'll file a bug and a doc update request instead!

fool commented 6 years ago

closing in favor of https://github.com/netlify/bitballoon/issues/1660