netlify / open-api

Open API specification of Netlify's API
https://open-api.netlify.com/#/default
MIT License
263 stars 84 forks source link

fix: al2 uploads need to have function name in SHA #509

Closed Skn0tt closed 1 year ago

Skn0tt commented 1 year ago

There's a detailed writeup of why this is necessary in https://linear.app/netlify/issue/COM-95/bug-what-happens-when-we-upload-two-functions-with-the-exact-identical.

In short: Netlify requires two different functions to have separate hashsums. Before, this was the case because every ZIP contained the function name as the entrypoint filename. With the changes in #505, this will now always be bootstrap, so it doesn't effect the hashsum anymore. By adding the filename as a comment, we get back this behaviour.

netlify[bot] commented 1 year ago

Deploy Preview for open-api ready!

Name Link
Latest commit 418eb970de965c756c8c0b8b9b315d25b873007c
Latest deploy log https://app.netlify.com/sites/open-api/deploys/653f9623a4633200083f70cb
Deploy Preview https://deploy-preview-509--open-api.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.