search

netlify / open-api

Open API specification of Netlify's API
https://open-api.netlify.com/#/default
MIT License
263 stars 84 forks source link

refactor: replace promisify with fs/promises version on convert.js #522

Closed hereje closed 10 months ago

hereje commented 11 months ago

refactor: replace make-dir with fs/mkdir

Related to https://github.com/netlify/cli/issues/3941

hereje commented 10 months ago

One small comment. And then I'm curious if there's a way to make the package.json have less changes. Since there's a lot because it's changing from V1 to V3 - would it be possible to have it keep the old format? It'd be nicer to change the format in a specific PR.

Sorry, My mistake.

I will do it through:

npm install --lockfile-version 1
kitop commented 10 months ago

@hereje thanks for the update! Unfortunately, seems like there's still a lot of additions to the package-lock.json, like adding webpack, source-map and others that were not there before.

I've tried the same change in the package.json locally (remove mk-dir and add the engines definition) and here's the diff I get: https://gist.github.com/kitop/9b53d60e4b2650bc0a03f6036ac76477

Any reason why the other dependencies where added? I'd like to keep the package-lock.json as clean as possible.

hereje commented 10 months ago

@hereje thanks for the update! Unfortunately, seems like there's still a lot of additions to the package-lock.json, like adding webpack, source-map and others that were not there before.

I've tried the same change in the package.json locally (remove mk-dir and add the engines definition) and here's the diff I get: https://gist.github.com/kitop/9b53d60e4b2650bc0a03f6036ac76477

Any reason why the other dependencies where added? I'd like to keep the package-lock.json as clean as possible.

Yeah, it seems I poluted the file when I made a dependency install.

I have fixed the issue.

netlify[bot] commented 10 months ago

Deploy Preview for open-api ready!

Name Link
Latest commit 551cbc0e51bd87da4233d8e8875c2a881dd5655a
Latest deploy log https://app.netlify.com/sites/open-api/deploys/65a5671930912d0008d1d6d3
Deploy Preview https://deploy-preview-522--open-api.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.