search

netlify / remix-template

Deploy your Remix site to Netlify
83 stars 27 forks source link

chore: updated @netlify/remix-edge-adapter to 1.2.0 #109

Closed nickytonline closed 1 year ago

nickytonline commented 1 year ago

Description

Updates the @netlify/remix-edge-adapter which brings in updates to the default remix configuration.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

  1. Ensure the Netlify CLI is installed and up to date.

  2. There are two test scenarios:

    • Create a Remix app using TypeScript for Netlify Edge Functions
    • Create a Remix app using JavaScript for Netlify Edge Functions

  3. For each scenario, it always starts by running the following from the root folder in a shell.

npx create-remix@latest --template ./
  1. The CLI will prompt for a location for the project.
❯ npx create-remix@latest --template ./
? Where would you like to create your app? (./my-remix-app)

Ensure that the location is outside of the Netlify Remix template folder, e.g. ../my-remix-app

  1. The Remix CLI will prompt you to choose TypeScript or JavaScript. Choose accordingly for the given test scenarios mentioned above.
? TypeScript or JavaScript? (Use arrow keys)
❯ TypeScript 
  JavaScript
  1. The Remix CLI will prompt you to install packages, press the ENTER to accept the default answer of Yes
? Do you want me to run `npm install`? (Y/n)

The npm packages will install.

  1. Some files will be manipulated if JavaScript is selected. The Remix CLI will output something similar to this.
⠹ Creating your app…⠋ Migrating template to JavaScript…Processing 3 files... 
Spawning 3 workers...
Sending 1 files to free worker...
Sending 1 files to free worker...
Sending 1 files to free worker...
⠴ Migrating template to JavaScript… SKIP /Users/nicktaylor/dev/remix-tests/edgy-ts/globals.d.ts
⠦ Migrating template to JavaScript… OKK /Users/nicktaylor/dev/remix-tests/edgy-ts/remix.init/root.tsx
 OKK /Users/nicktaylor/dev/remix-tests/edgy-ts/remix.init/entry.server.tsx
All done. 
Results: 
0 errors
0 unmodified
1 skipped
2 ok
Time elapsed: 0.428seconds
  1. The Remix CLI extended with our questions will prompt to create the app with Netlify Functions or Netlify Edge Functions.
💿 Running remix.init script
? Run your Remix site with: (Use arrow keys)
    Netlify Functions - Choose this for stable support for production sites 
 ❯ Netlify Edge Functions (beta) - Try this for improved performance on non-critical sites
  1. Select Netlify Edge Functions by pressing the ENTER key.

Test `netlify dev``

  1. Run
netlify dev
  1. The Remix dev server starts up.
  2. Navigate to https://localhost:8888 and the page loads.
  3. Make some changes to the text in app/routes/index.tsx (or jsx)
  4. The page reloads with the changes.

image For us to review and ship your PR efficiently, please perform the following steps:

Test with Netlify CLI netlify serve

  1. Run npm run start or netlify serve
  2. netlify serve runs (not the Remix dev server)
  3. Navigate to https://localhost:8888 and the page loads.

For us to review and ship your PR efficiently, please perform the following steps:

A picture of a cute animal (not mandatory, but encouraged)

netlify[bot] commented 1 year ago

Deploy Preview for remix-edge-on ready!

Name Link
Latest commit d7b4bcb62f6680c13c77d1986bf88ff3ce211a9e
Latest deploy log https://app.netlify.com/sites/remix-edge-on/deploys/641ddf822bdb4c00079ad014
Deploy Preview https://deploy-preview-109--remix-edge-on.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.