search

netlify / remix-template

Deploy your Remix site to Netlify
83 stars 27 forks source link

fix: fixed v2 routing for Netlify functions template #113

Closed nickytonline closed 1 year ago

nickytonline commented 1 year ago

Description

I made changes to the Netlify Edge Functions template for Remix. but forgot to add the future config for the Netlify Functions template.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

You can ignore the deploy preview. There is nothing there.

  1. Pull this down, e.g. via the GitHub CLI, gh co 112
  2. From the root of the project, run npx create-remix@latest --template ./
  3. Choose a folder to generate the remix app. Ensure it's outside of the template project. Othewise, you'll receive the following error ⠋ Creating your app…Cannot copy './' to a subdirectory of itself, '/Users/nicktaylor/dev/work/remix-template/my-remix-app'..
➜ npx create-remix@latest --template ./             
? Where would you like to create your app? (./my-remix-app)
  1. Choose TypeScript (the default). It doesn't matter if you choose JavaScript or TypeScript for this fix.
? TypeScript or JavaScript? (Use arrow keys)
❯ TypeScript 
  JavaScript
  1. Install the dependencies
? Do you want me to run `npm install`? (Y/n)
  1. Select Netlify Functions
💿 Running remix.init script
? Run your Remix site with: 
❯ Netlify Functions - Choose this for stable support for production sites 
 Netlify Edge Functions (beta) - Try this for improved performance on less critical sites
  1. From the shell, switch to the root of your new project, e.g. cd ../my-project
  2. Run netlify dev
  3. The site loads up at http://localhost:8888
  4. Stop the development server.
  5. Ensure the site still serves correctly for production by running netlify serve
  6. The site loads up at http://localhost:8888

CleanShot 2023-04-04 at 19 28 45

For us to review and ship your PR efficiently, please perform the following steps:

A picture of a cute animal (not mandatory, but encouraged)

an alpaca moving their ears
netlify[bot] commented 1 year ago

Deploy Preview for remix-edge-on ready!

Name Link
Latest commit a57625f657551e6574fcfa3d8ff867e592db3e22
Latest deploy log https://app.netlify.com/sites/remix-edge-on/deploys/6436ba1b4ef0800008077a28
Deploy Preview https://deploy-preview-113--remix-edge-on.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.