netlify / remix-template

Deploy your Remix site to Netlify
83 stars 27 forks source link

feat: bring in line with latest official Remix templates #115

Closed MichaelDeBoey closed 8 months ago

MichaelDeBoey commented 1 year ago

CC/ @ascorbic @nickytonline

netlify[bot] commented 1 year ago

Deploy request for remix-edge-on pending review.

Visit the deploys page to approve it

Name Link
Latest commit 0564547160e7ebe2cf0b20e964bb101c6ba1777b
MichaelDeBoey commented 1 year ago

@nickytonline Anything I still need to do in order to get this one merged?

nickytonline commented 1 year ago

Hi @MichaelDeBoey! I didn't forget about this. Just a bunch of other things going on atm. I'll take a peek at this tomorrow to see if there's anything else that needs to be done.

MichaelDeBoey commented 1 year ago

@nickytonline Only thing I can't do is use @netlify/edge-adapter v2 as it's not yet published on npm, only a GitHub release is made

nickytonline commented 1 year ago

@MichaelDeBoey, I was away last week. It looks like npm ci failed because the lock file wasn't right. We have a new release coming soon, so probably just wait for that one.

MichaelDeBoey commented 1 year ago

@nickytonline Let me know when we can merge this one

nickytonline commented 1 year ago

@MichaelDeBoey, I was away last week. It looks like npm ci failed because the lock file wasn't right. We have a new release coming soon, so probably just wait for that one.

@MichaelDeBoey we haven't released a new version yet. I didn't forget about this! 😅

MichaelDeBoey commented 1 year ago

@nickytonline These updates aren't accounting for @netlify/remix-edge-adapter v2 yet, so install should just work

It seems like cache is stuck on Remix v1.14 though for some reason 🤔

MichaelDeBoey commented 1 year ago

@nickytonline Any ETA on a new release? I'd love to get this one merged, especially since we started pointing to this template (and the adapters) in our V2 upgrade docs: https://remix.run/pages/v2#netlify-adapter

netlify[bot] commented 11 months ago

Deploy request for remix-on pending review.

Visit the deploys page to approve it

Name Link
Latest commit 0564547160e7ebe2cf0b20e964bb101c6ba1777b
ascorbic commented 8 months ago

Closing this because the templates have been rewritten to support Vite. Thanks for contributing