netlify / remix-template

Deploy your Remix site to Netlify
83 stars 27 forks source link

feat: replace _redirects workaround with preferStatic #133

Closed Skn0tt closed 10 months ago

Skn0tt commented 11 months ago

It's important that the SSR function matches all paths, except for the ones that have static files. In the past, _redirects was the way to achieve that - but with V2 Functions, in-source-config is much easier to reason about. Now that we have preferStatic, we can scratch the _redirects workaround and use in-source-config instead!

Keeping this as draft until i've manually verified that it works as intended. One of the challenges is that the Remix compiler will turn true into !0, but https://github.com/netlify/zip-it-and-ship-it/pull/1665 should help us handle that.

netlify[bot] commented 11 months ago

Deploy Preview for remix-edge-on ready!

Name Link
Latest commit 34cdb855d8b96017f4fe4b953961f2675ae42e10
Latest deploy log https://app.netlify.com/sites/remix-edge-on/deploys/65674442798bd20008b09356
Deploy Preview https://deploy-preview-133--remix-edge-on.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 11 months ago

Deploy Preview for remix-on ready!

Name Link
Latest commit 34cdb855d8b96017f4fe4b953961f2675ae42e10
Latest deploy log https://app.netlify.com/sites/remix-on/deploys/656744423c1fdc00084e6ff5
Deploy Preview https://deploy-preview-133--remix-on.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Skn0tt commented 11 months ago

Oh hey, there's deploy previews for this site - neat! Looks like it's working alright :D

Skn0tt commented 10 months ago

We've started deleting .netlify/functions-internal on startup of netlify dev - so no, that won't happen!

ascorbic commented 10 months ago

I've not tested this, but approving on the basis that you've tested the template in dev locally