Closed nickytonline closed 8 months ago
Currently the deploy preview makes no sense once #83 is merged. The new template supports selecting:
The Remix CLI and remix.init script we have rely on inquirer.js. To be able to generate the templates in CI, we'd need to mock inquirer.js.
Once we are able to generate the apps for all the scenarios above, we could run a local version in the GH action that we could used for E2E tests.
So pre-steps instead of waiting for a deploy preview would be:
ntl build --offline
ntl serve
Having this in place would have prevented #90.
It would also be good to add an image that validates that exluded_patterns: ["_assets/*"] doesn't break. Note, it currently works well.
exluded_patterns: ["_assets/*"]
These should generate sites nightly as things move fast. See #110.
Currently the deploy preview makes no sense once #83 is merged. The new template supports selecting:
The Remix CLI and remix.init script we have rely on inquirer.js. To be able to generate the templates in CI, we'd need to mock inquirer.js.
Once we are able to generate the apps for all the scenarios above, we could run a local version in the GH action that we could used for E2E tests.
So pre-steps instead of waiting for a deploy preview would be:
ntl build --offline
.ntl serve
Having this in place would have prevented #90.