search

netlify / remix-template

Deploy your Remix site to Netlify
83 stars 27 forks source link

Add E2E Tests for the 4 types of apps that can be created #90

Closed nickytonline closed 8 months ago

nickytonline commented 1 year ago

Currently the deploy preview makes no sense once #83 is merged. The new template supports selecting:

The Remix CLI and remix.init script we have rely on inquirer.js. To be able to generate the templates in CI, we'd need to mock inquirer.js.

Once we are able to generate the apps for all the scenarios above, we could run a local version in the GH action that we could used for E2E tests.

So pre-steps instead of waiting for a deploy preview would be:

  1. generate new app for scenario x
  2. Run ntl build --offline.
  3. Run ntl serve
  4. Run E2E tests based off of http://localhost:8888

Having this in place would have prevented #90.

nickytonline commented 1 year ago

It would also be good to add an image that validates that exluded_patterns: ["_assets/*"] doesn't break. Note, it currently works well.

nickytonline commented 1 year ago

These should generate sites nightly as things move fast. See #110.