Closed nickytonline closed 1 year ago
Name | Link |
---|---|
Latest commit | d977e5634527fdacd37bf2a5181e0e7d5cc4e04e |
Latest deploy log | https://app.netlify.com/sites/remix-edge-on/deploys/6400f7be01eeba0008166be5 |
Deploy Preview | https://deploy-preview-95--remix-edge-on.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
The behaviour for all other frameworks is for netlify dev
to run the framework's dev server. The only reason Remix is different is because when we first added it, there was no remix dev
command. I think we should do the same here: use the dev server for netlify dev. If people want to try a production build, they can use netlify serve.
The behaviour for all other frameworks is for
netlify dev
to run the framework's dev server. The only reason Remix is different is because when we first added it, there was noremix dev
command. I think we should do the same here: use the dev server for netlify dev. If people want to try a production build, they can use netlify serve.
~The problem with using remix dev
is it does not support custom server configurations which is why we went with remix watch
, i.e. serverBuildTarget: "netlify",
in remix.config.js. Other server build targets have the same issue as far as I know.~ Actually looking at some other providers, we can pretty much omit the serverBuildTarget
as all we're doing with it is setting this which I can set in the remix.config.js
serverBuildPath = ".netlify/functions-internal/server.js";
I'll try that out.
Giving you a tag @whitep4nth3r as we'll be syncing up on this Thursday.
Description
This fix when the
Functions Template
is selected, allows a developer to usenpm run dev
as they would expect, i.e. runremix dev
and at the same time allow for use of the Netlify CLI (remix watch).Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Ensure that the location is outside of the Netlify Remix template folder, e.g.
../my-remix-app
The npm packages will install.
10 Select Netlify Functions by pressing the ENTER key.
../my-remix-app
netlify.toml
for the project should be the same as the one in this PR.npm install
Test
remix dev
Test with Netlify CLI
ntl dev
ntl dev
https://localhost:8888
and the page loads.For us to review and ship your PR efficiently, please perform the following steps:
Test with Netlify CLI
ntl serve
npm run start
ntl serve runs
(not the Remix dev server)_custom_redirects
file gets copied topublic/_redirects
https://localhost:8888
and the page loads.For us to review and ship your PR efficiently, please perform the following steps:
A picture of a cute animal (not mandatory, but encouraged)