search

netlify / terraform-provider-netlify

MIT License
2 stars 2 forks source link

add initial site resource #56

Open BeryJu opened 2 months ago

BeryJu commented 2 months ago

39

Add initial resource for creating a Site. Doesn't have too many settings as most of them are covered by netlify_site_build_settings. Probably some clunky code as I've mainly used SDKv2 instead of TF Framework

ramonsnir commented 2 months ago

Thanks @BeryJu for contributing!

I will review this later, and I need to discuss with a few people internally to make sure this is future-proof as the site resource is very complicated.

Have you tried to use this resource for your own account? Can you share a wider example of how you used it? Obviously, with sensitive information redacted.

BeryJu commented 2 months ago

Thanks @BeryJu for contributing!

I will review this later, and I need to discuss with a few people internally to make sure this is future-proof as the site resource is very complicated.

Yeah that's fair, I assumed that it wasn't going to be simple but hopefully #39 can be done a bit faster

Have you tried to use this resource for your own account? Can you share a wider example of how you used it? Obviously, with sensitive information redacted.

I haven't tried this with my real account yet, but I have tried it with a test netlify account (both the acceptance tests and a separate test setup) and it does create the site correctly. The main idea for using this is with @goauthentik where we'd like to automate having a site for each release which we currently do with branch domains but that is not quite flexible enough. (We currently have 40 releases that would map to 40 sites but this will increase in the future)

ramonsnir commented 1 month ago

See my comment here: https://github.com/netlify/terraform-provider-netlify/issues/39#issuecomment-2419446752

We currently believe that this approach would create sites with limited functionality, so we're holding off until we have a solution (or we are sure that sites starting this way can be upgraded/hydrated).