netlify / zip-it-and-ship-it

Intelligently prepare Node.js Lambda functions for deployment
https://www.npmjs.com/package/@netlify/zip-it-and-ship-it
MIT License
316 stars 35 forks source link

fix: remove functions_inherit_build_nodejs_version flag #1551

Closed Skn0tt closed 1 year ago

Skn0tt commented 1 year ago

The flag has been rolled out fully for a while, let's remove it.

github-actions[bot] commented 1 year ago

⏱ Benchmark results

Comparing with 0fb6f5097166d94557f4c3b843efbfb4c12be44d

largeDepsEsbuild: 3.1s

⬇️ 4.69% decrease vs. 0fb6f5097166d94557f4c3b843efbfb4c12be44d

^                                                                   3.7s                                  
│                                                           3.6s    ┌──┐                                  
│                                   3.4s                    ┌──┐    |  |                                  
│                                   ┌──┐                    |  |    |  |    3.2s            3.2s    3.1s  
│                                   |  |                    |  |    |  |    ┌──┐            ┌──┐    ┌──┐  
│ ──2.7s────────────────────────────┼──┼────────────────────┼──┼────┼──┼────┼──┼────────────┼──┼────|▒▒|──
│   ┌──┐            2.6s    2.5s    |  |    2.7s    2.6s    |  |    |  |    |  |    2.6s    |  |    |▒▒|  
│   |  |    2.4s    ┌──┐    ┌──┐    |  |    ┌──┐    ┌──┐    |  |    |  |    |  |    ┌──┐    |  |    |▒▒|  
│   |  |    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend - T-30 (2b709287c4375931a6a3b042d44043dee41c925e): 3.4s - T-29 (13f5034703294df18ae927f353320611ea422502): 2.6s - T-28 (70de5420f1cf51e0d03ff896949b5a85fb35dc93): 3s - T-27 (6c37ad5b44e36e5f75ad670f4b316b34189f4417): 3.1s - T-26 (441ac38c595653d7455cbf0717a43f7a63e733a5): 2.5s - T-25 (019e3e58061168f36a3b5480477e1f959ff9840d): 2.7s - T-24 (e7ac14fb5b8a7745fe59bbc370d7ae4faf296b28): 3.4s - T-23 (abf8927d0db7b608e119f132ac935caa8dcfbd65): 2.5s - T-22 (34257036089793269032b010ee01d2fd7f7429c5): 3.8s - T-21 (abfe88eddcb3068f9ea890dbd29994bd92d7acd7): 3s - T-20 (13525a5cb4aefb0b3bee14edb8672a13f9ccfc9f): 2.6s - T-19 (52b6b2809ff5d53f0d63569e42d9f40192681201): 2.5s - T-18 (ba3587d5e5a56fe9b5ec4f566ed154e3c4c90318): 2.7s - T-17 (bcb9a574dc9476fdfc1d7c5efc925b72bf69bab9): 2.4s - T-16 (5f1e22ca707ca1847dcd33fbe8b781244b6b665e): 2.8s - T-15 (836b6d57fa70c816c2eddb8e52edda40f8ec82a2): 2.8s - T-14 (1493824dc7bda7ebe71a3600d9ed5d01a91aea75): 2.5s - T-13 (e9b4de1635e6966b1a8c432197fa4a29d745573f): 2.6s - T-12 (dd45407ff62ccf843101d79eb412e06baed5bf45): 2.7s - T-11 (4d7c87a73702debbbf469b20f5686a0148235f02): 2.4s - T-10 (934641021924a1d5ae19e59094e477ed5b68cb88): 2.6s - T-9 (fca555f9289b90bdfded773b90224fb0ddae5d41): 2.5s - T-8 (82774450c6b90a48c716d635632d69888af5201d): 3.4s - T-7 (ed67667b233f58281cba699075f7c60d1dad8be0): 2.7s - T-6 (af24f845faf217a1e4b47c41a1a055d52a92dc17): 2.6s - T-5 (235eb7035790b4fa66314e0130c8389d8d4399b0): 3.6s - T-4 (0136042fde6ab59cb9263f4d8e15e35361fdef4c): 3.7s - T-3 (33e0e499ccce537145ee2ea064efe1501958fd64): 3.2s - T-2 (4d018d4ec9a1654eb471d5c34e553ac81dc4d5a3): 2.6s - T-1 (0fb6f5097166d94557f4c3b843efbfb4c12be44d): 3.2s - **T (current commit): 3.1s**

largeDepsNft: 10.1s

⬆️ 5.83% increase vs. 0fb6f5097166d94557f4c3b843efbfb4c12be44d

^                                                          11.5s   11.6s                                  
│                                  11.1s                    ┌──┐    ┌──┐                                  
│                                   ┌──┐                    |  |    |  |   10.3s                          
│                                   |  |                    |  |    |  |    ┌──┐                   10.1s  
│                                   |  |                    |  |    |  |    |  |            9.5s    ┌──┐  
│ ──8.4s────────────────────────────┼──┼────────────────────┼──┼────┼──┼────┼──┼────────────┌──┐────|▒▒|──
│   ┌──┐            8.3s    7.8s    |  |    7.9s    8.2s    |  |    |  |    |  |    8.1s    |  |    |▒▒|  
│   |  |    7.5s    ┌──┐    ┌──┐    |  |    ┌──┐    ┌──┐    |  |    |  |    |  |    ┌──┐    |  |    |▒▒|  
│   |  |    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend - T-30 (2b709287c4375931a6a3b042d44043dee41c925e): 11.6s - T-29 (13f5034703294df18ae927f353320611ea422502): 7.9s - T-28 (70de5420f1cf51e0d03ff896949b5a85fb35dc93): 9.6s - T-27 (6c37ad5b44e36e5f75ad670f4b316b34189f4417): 10.1s - T-26 (441ac38c595653d7455cbf0717a43f7a63e733a5): 7.5s - T-25 (019e3e58061168f36a3b5480477e1f959ff9840d): 8.4s - T-24 (e7ac14fb5b8a7745fe59bbc370d7ae4faf296b28): 11.5s - T-23 (abf8927d0db7b608e119f132ac935caa8dcfbd65): 7.8s - T-22 (34257036089793269032b010ee01d2fd7f7429c5): 11.8s - T-21 (abfe88eddcb3068f9ea890dbd29994bd92d7acd7): 10.1s - T-20 (13525a5cb4aefb0b3bee14edb8672a13f9ccfc9f): 8s - T-19 (52b6b2809ff5d53f0d63569e42d9f40192681201): 8s - T-18 (ba3587d5e5a56fe9b5ec4f566ed154e3c4c90318): 8.2s - T-17 (bcb9a574dc9476fdfc1d7c5efc925b72bf69bab9): 7.6s - T-16 (5f1e22ca707ca1847dcd33fbe8b781244b6b665e): 9.6s - T-15 (836b6d57fa70c816c2eddb8e52edda40f8ec82a2): 8.9s - T-14 (1493824dc7bda7ebe71a3600d9ed5d01a91aea75): 8.1s - T-13 (e9b4de1635e6966b1a8c432197fa4a29d745573f): 8.5s - T-12 (dd45407ff62ccf843101d79eb412e06baed5bf45): 8.4s - T-11 (4d7c87a73702debbbf469b20f5686a0148235f02): 7.5s - T-10 (934641021924a1d5ae19e59094e477ed5b68cb88): 8.3s - T-9 (fca555f9289b90bdfded773b90224fb0ddae5d41): 7.8s - T-8 (82774450c6b90a48c716d635632d69888af5201d): 11.1s - T-7 (ed67667b233f58281cba699075f7c60d1dad8be0): 7.9s - T-6 (af24f845faf217a1e4b47c41a1a055d52a92dc17): 8.2s - T-5 (235eb7035790b4fa66314e0130c8389d8d4399b0): 11.5s - T-4 (0136042fde6ab59cb9263f4d8e15e35361fdef4c): 11.6s - T-3 (33e0e499ccce537145ee2ea064efe1501958fd64): 10.3s - T-2 (4d018d4ec9a1654eb471d5c34e553ac81dc4d5a3): 8.1s - T-1 (0fb6f5097166d94557f4c3b843efbfb4c12be44d): 9.5s - **T (current commit): 10.1s**

largeDepsZisi: 19.3s

⬆️ 9.00% increase vs. 0fb6f5097166d94557f4c3b843efbfb4c12be44d

^                                                          21.8s   21.6s                                  
│                                   21s                     ┌──┐    ┌──┐                                  
│                                   ┌──┐                    |  |    |  |                           19.3s  
│                                   |  |                    |  |    |  |    19s                     ┌──┐  
│                                   |  |                    |  |    |  |    ┌──┐           17.6s    |▒▒|  
│ ─16.2s───────────16.5s────────────┼──┼────────────────────┼──┼────┼──┼────┼──┼────────────┌──┐────|▒▒|──
│   ┌──┐   14.8s    ┌──┐   15.3s    |  |   15.7s   15.6s    |  |    |  |    |  |   14.9s    |  |    |▒▒|  
│   |  |    ┌──┐    |  |    ┌──┐    |  |    ┌──┐    ┌──┐    |  |    |  |    |  |    ┌──┐    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend - T-30 (2b709287c4375931a6a3b042d44043dee41c925e): 21.3s - T-29 (13f5034703294df18ae927f353320611ea422502): 15s - T-28 (70de5420f1cf51e0d03ff896949b5a85fb35dc93): 19.3s - T-27 (6c37ad5b44e36e5f75ad670f4b316b34189f4417): 19.5s - T-26 (441ac38c595653d7455cbf0717a43f7a63e733a5): 14.6s - T-25 (019e3e58061168f36a3b5480477e1f959ff9840d): 16.2s - T-24 (e7ac14fb5b8a7745fe59bbc370d7ae4faf296b28): 22.1s - T-23 (abf8927d0db7b608e119f132ac935caa8dcfbd65): 14.5s - T-22 (34257036089793269032b010ee01d2fd7f7429c5): 22.4s - T-21 (abfe88eddcb3068f9ea890dbd29994bd92d7acd7): 19s - T-20 (13525a5cb4aefb0b3bee14edb8672a13f9ccfc9f): 15.6s - T-19 (52b6b2809ff5d53f0d63569e42d9f40192681201): 15.1s - T-18 (ba3587d5e5a56fe9b5ec4f566ed154e3c4c90318): 15.7s - T-17 (bcb9a574dc9476fdfc1d7c5efc925b72bf69bab9): 14.6s - T-16 (5f1e22ca707ca1847dcd33fbe8b781244b6b665e): 18.2s - T-15 (836b6d57fa70c816c2eddb8e52edda40f8ec82a2): 17.2s - T-14 (1493824dc7bda7ebe71a3600d9ed5d01a91aea75): 15.4s - T-13 (e9b4de1635e6966b1a8c432197fa4a29d745573f): 16.3s - T-12 (dd45407ff62ccf843101d79eb412e06baed5bf45): 16.2s - T-11 (4d7c87a73702debbbf469b20f5686a0148235f02): 14.8s - T-10 (934641021924a1d5ae19e59094e477ed5b68cb88): 16.5s - T-9 (fca555f9289b90bdfded773b90224fb0ddae5d41): 15.3s - T-8 (82774450c6b90a48c716d635632d69888af5201d): 21s - T-7 (ed67667b233f58281cba699075f7c60d1dad8be0): 15.7s - T-6 (af24f845faf217a1e4b47c41a1a055d52a92dc17): 15.6s - T-5 (235eb7035790b4fa66314e0130c8389d8d4399b0): 21.8s - T-4 (0136042fde6ab59cb9263f4d8e15e35361fdef4c): 21.6s - T-3 (33e0e499ccce537145ee2ea064efe1501958fd64): 19s - T-2 (4d018d4ec9a1654eb471d5c34e553ac81dc4d5a3): 14.9s - T-1 (0fb6f5097166d94557f4c3b843efbfb4c12be44d): 17.6s - **T (current commit): 19.3s**