search

netlify / zip-it-and-ship-it

Intelligently prepare Node.js Lambda functions for deployment
https://www.npmjs.com/package/@netlify/zip-it-and-ship-it
MIT License
316 stars 35 forks source link

fix: output `provided.al2` also when zipGo is disabled #1609

Closed Skn0tt closed 1 year ago

Skn0tt commented 1 year ago

We were only emitting runtimeVersion: "provided.al2" when zipGo is enabled. In Buildbot deploys, this is disabled, so we weren't emitting provided.al2 properly! This PR fixes that.

I also noticed we weren't emitting generator and runtimeVersion when zipGo is enabled. I don't think that's intended, so I changed it as well.

github-actions[bot] commented 1 year ago

⏱ Benchmark results

Comparing with fffff2193787ccc260c2e8eff83128d10e788139

largeDepsEsbuild: 3.5s

⬆️ 23.82% increase vs. fffff2193787ccc260c2e8eff83128d10e788139

^           3.6s                                            3.6s                                    3.5s  
│           ┌──┐            3.4s                            ┌──┐                                    ┌──┐  
│           |  |    3.2s    ┌──┐            3.2s            |  |    3.2s                            |▒▒|  
│           |  |    ┌──┐    |  |            ┌──┐            |  |    ┌──┐                            |▒▒|  
│ ──────────┼──┼────┼──┼────┼──┼────2.8s────┼──┼────────────┼──┼────┼──┼────2.8s────────────────────|▒▒|──
│           |  |    |  |    |  |    ┌──┐    |  |    2.7s    |  |    |  |    ┌──┐    2.7s    2.7s    |▒▒|  
│   2.5s    |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    ┌──┐    ┌──┐    |▒▒|  
│   ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T
Legend - T-30 (60d1ecb24a678806e75d329da23963c51f246d62): 2.8s - T-29 (4778ed749c03eaae2fb36b42db987364c7e0ecf3): 2.8s - T-28 (f5529d7f1e2008db4ef41392571733250e0b2d12): 2.8s - T-27 (d98dd20825b80d78c6ff0e5c4f2b51c7117d6af5): 2.6s - T-26 (6be379e1499d09e146d718af1957275014d10dd4): 2.7s - T-25 (ad2c55d2db23014e0961a776f860e03d781a8eb1): 2.8s - T-24 (304f7f544dfd99ddd3447e18baa1768e06aa646c): 2.6s - T-23 (45ebfeaa3c41aa0af7e8c4e5f7ad0fd0410e13eb): 3.1s - T-22 (2070b46a2c2949b93f9c98f14135f3f76e7db65d): 3.7s - T-21 (5d277e792ad684d29fb95780d2dee162874d3265): 2.7s - T-20 (360f3733e2db910f8e3372f2765b421065d6bf9b): 2.4s - T-19 (5c6c14a08b9d4868bd26cc989262f9e624251a4a): 2.7s - T-18 (1ea5222b0723885c908642390253f9496f378d5f): 2.6s - T-17 (4e2fe8bd69cd9a8b8e5a6b5deb821bf409e378f9): 3s - T-16 (25c1ae4b7522fa328aab3376549e60e902b4b308): 2.6s - T-15 (90325b260492360cc4a4f25630a303d50e7fb394): 2.7s - T-14 (1eccedc3433fe06ab32c3b19f055b77a563515b6): 2.8s - T-13 (c9e5384cbd834396648e3415d677191780dcff11): 2.6s - T-12 (b40788aa9265f117d373cf059b3a0061f0e69953): 2.5s - T-11 (6ff4fbefe2bd4fd83838b29fbd4c60e498aeaad8): 3.6s - T-10 (dfe6dd0aa9a7e914dc2b933adae54596b81ae40e): 3.2s - T-9 (6b85304833228a7643e2284fb1929b13bec54904): 3.4s - T-8 (cd48552ef96dca0cd1120ae8f85905ef860f0ae8): 2.8s - T-7 (cf77a728cbb492a8cdaa7f07f72a1f9e25cc6a54): 3.2s - T-6 (722a724ccf8af8e6f265544ae747cadb19526edf): 2.7s - T-5 (9e3af6a8aaee7e343d770b5ff3f5b854a5e92f59): 3.6s - T-4 (7eb97de88cee636384a29b562cc03f2489bbe99a): 3.2s - T-3 (6be8b420590cd6daa54b72310d5f184b767854ef): 2.8s - T-2 (23405c64e8f3f27b8e384d47dfddd727dd9f9898): 2.7s - T-1 (fffff2193787ccc260c2e8eff83128d10e788139): 2.7s - **T (current commit): 3.5s**

largeDepsNft: 11.1s

⬆️ 24.36% increase vs. fffff2193787ccc260c2e8eff83128d10e788139

^          11.8s                                           11.6s                                          
│           ┌──┐                                            ┌──┐                                   11.1s  
│           |  |           10.5s                            |  |                                    ┌──┐  
│           |  |            ┌──┐           10.2s            |  |    9.8s                            |▒▒|  
│           |  |    9.4s    |  |            ┌──┐            |  |    ┌──┐                            |▒▒|  
│ ──────────┼──┼────┌──┐────┼──┼────8.5s────┼──┼────────────┼──┼────┼──┼────8.7s────────────────────|▒▒|──
│           |  |    |  |    |  |    ┌──┐    |  |    8.3s    |  |    |  |    ┌──┐    8.5s    8.4s    |▒▒|  
│   7.8s    |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    ┌──┐    ┌──┐    |▒▒|  
│   ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T
Legend - T-30 (60d1ecb24a678806e75d329da23963c51f246d62): 8.2s - T-29 (4778ed749c03eaae2fb36b42db987364c7e0ecf3): 8.3s - T-28 (f5529d7f1e2008db4ef41392571733250e0b2d12): 8.7s - T-27 (d98dd20825b80d78c6ff0e5c4f2b51c7117d6af5): 7.6s - T-26 (6be379e1499d09e146d718af1957275014d10dd4): 8.5s - T-25 (ad2c55d2db23014e0961a776f860e03d781a8eb1): 8.3s - T-24 (304f7f544dfd99ddd3447e18baa1768e06aa646c): 8.1s - T-23 (45ebfeaa3c41aa0af7e8c4e5f7ad0fd0410e13eb): 10.1s - T-22 (2070b46a2c2949b93f9c98f14135f3f76e7db65d): 12.1s - T-21 (5d277e792ad684d29fb95780d2dee162874d3265): 8.3s - T-20 (360f3733e2db910f8e3372f2765b421065d6bf9b): 7.5s - T-19 (5c6c14a08b9d4868bd26cc989262f9e624251a4a): 8s - T-18 (1ea5222b0723885c908642390253f9496f378d5f): 7.7s - T-17 (4e2fe8bd69cd9a8b8e5a6b5deb821bf409e378f9): 9.3s - T-16 (25c1ae4b7522fa328aab3376549e60e902b4b308): 7.9s - T-15 (90325b260492360cc4a4f25630a303d50e7fb394): 8.4s - T-14 (1eccedc3433fe06ab32c3b19f055b77a563515b6): 8.4s - T-13 (c9e5384cbd834396648e3415d677191780dcff11): 8.3s - T-12 (b40788aa9265f117d373cf059b3a0061f0e69953): 7.8s - T-11 (6ff4fbefe2bd4fd83838b29fbd4c60e498aeaad8): 11.8s - T-10 (dfe6dd0aa9a7e914dc2b933adae54596b81ae40e): 9.4s - T-9 (6b85304833228a7643e2284fb1929b13bec54904): 10.5s - T-8 (cd48552ef96dca0cd1120ae8f85905ef860f0ae8): 8.5s - T-7 (cf77a728cbb492a8cdaa7f07f72a1f9e25cc6a54): 10.2s - T-6 (722a724ccf8af8e6f265544ae747cadb19526edf): 8.3s - T-5 (9e3af6a8aaee7e343d770b5ff3f5b854a5e92f59): 11.6s - T-4 (7eb97de88cee636384a29b562cc03f2489bbe99a): 9.8s - T-3 (6be8b420590cd6daa54b72310d5f184b767854ef): 8.7s - T-2 (23405c64e8f3f27b8e384d47dfddd727dd9f9898): 8.5s - T-1 (fffff2193787ccc260c2e8eff83128d10e788139): 8.4s - **T (current commit): 11.1s**

largeDepsZisi: 20.8s

⬆️ 20.56% increase vs. fffff2193787ccc260c2e8eff83128d10e788139

^          21.9s                                           21.8s                                          
│           ┌──┐                                            ┌──┐                                   20.8s  
│           |  |           20.3s           19.9s            |  |   19.4s                            ┌──┐  
│           |  |   18.3s    ┌──┐            ┌──┐            |  |    ┌──┐                            |▒▒|  
│ ──────────┼──┼────┌──┐────┼──┼────────────┼──┼────────────┼──┼────┼──┼────────────────────────────|▒▒|──
│           |  |    |  |    |  |   16.4s    |  |   16.2s    |  |    |  |   16.8s   16.2s   16.5s    |▒▒|  
│           |  |    |  |    |  |    ┌──┐    |  |    ┌──┐    |  |    |  |    ┌──┐    ┌──┐    ┌──┐    |▒▒|  
│  14.8s    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T
Legend - T-30 (60d1ecb24a678806e75d329da23963c51f246d62): 15.8s - T-29 (4778ed749c03eaae2fb36b42db987364c7e0ecf3): 16.1s - T-28 (f5529d7f1e2008db4ef41392571733250e0b2d12): 16.4s - T-27 (d98dd20825b80d78c6ff0e5c4f2b51c7117d6af5): 14.8s - T-26 (6be379e1499d09e146d718af1957275014d10dd4): 16.1s - T-25 (ad2c55d2db23014e0961a776f860e03d781a8eb1): 15.9s - T-24 (304f7f544dfd99ddd3447e18baa1768e06aa646c): 15.5s - T-23 (45ebfeaa3c41aa0af7e8c4e5f7ad0fd0410e13eb): 19.3s - T-22 (2070b46a2c2949b93f9c98f14135f3f76e7db65d): 22.4s - T-21 (5d277e792ad684d29fb95780d2dee162874d3265): 15.7s - T-20 (360f3733e2db910f8e3372f2765b421065d6bf9b): 14.4s - T-19 (5c6c14a08b9d4868bd26cc989262f9e624251a4a): 15.7s - T-18 (1ea5222b0723885c908642390253f9496f378d5f): 15.1s - T-17 (4e2fe8bd69cd9a8b8e5a6b5deb821bf409e378f9): 17.9s - T-16 (25c1ae4b7522fa328aab3376549e60e902b4b308): 15.4s - T-15 (90325b260492360cc4a4f25630a303d50e7fb394): 16.3s - T-14 (1eccedc3433fe06ab32c3b19f055b77a563515b6): 15.9s - T-13 (c9e5384cbd834396648e3415d677191780dcff11): 15.7s - T-12 (b40788aa9265f117d373cf059b3a0061f0e69953): 14.8s - T-11 (6ff4fbefe2bd4fd83838b29fbd4c60e498aeaad8): 21.9s - T-10 (dfe6dd0aa9a7e914dc2b933adae54596b81ae40e): 18.3s - T-9 (6b85304833228a7643e2284fb1929b13bec54904): 20.3s - T-8 (cd48552ef96dca0cd1120ae8f85905ef860f0ae8): 16.4s - T-7 (cf77a728cbb492a8cdaa7f07f72a1f9e25cc6a54): 19.9s - T-6 (722a724ccf8af8e6f265544ae747cadb19526edf): 16.2s - T-5 (9e3af6a8aaee7e343d770b5ff3f5b854a5e92f59): 21.8s - T-4 (7eb97de88cee636384a29b562cc03f2489bbe99a): 19.4s - T-3 (6be8b420590cd6daa54b72310d5f184b767854ef): 16.8s - T-2 (23405c64e8f3f27b8e384d47dfddd727dd9f9898): 16.2s - T-1 (fffff2193787ccc260c2e8eff83128d10e788139): 16.5s - **T (current commit): 20.8s**