search

netlify / zip-it-and-ship-it

Intelligently prepare Node.js Lambda functions for deployment
https://www.npmjs.com/package/@netlify/zip-it-and-ship-it
MIT License
316 stars 35 forks source link

fix: drop runtimeVersion override for go functions #1676

Closed Skn0tt closed 12 months ago

Skn0tt commented 12 months ago

Part of https://github.com/netlify/pod-dev-foundations/issues/581. provided.al2 is the default runtime for Go functions now, so we don't need the override here anymore. Put the change behind a flag, so we can rollout gradually.

github-actions[bot] commented 12 months ago

⏱ Benchmark results

Comparing with be424b244ccea5bfb20f65ba127a32c24d345f27

largeDepsEsbuild: 1.4s

⬇️ 3.04% decrease vs. be424b244ccea5bfb20f65ba127a32c24d345f27

^   1.5s    1.5s            1.5s    1.4s                                            1.5s    1.5s          
│   ┌──┐    ┌──┐    1.4s    ┌──┐    ┌──┐    1.4s    1.4s    1.4s    1.4s    1.4s    ┌──┐    ┌──┐    1.4s  
│   |  |    |  |    ┌──┐    |  |    |  |    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    |  |    |  |    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T
Legend - T-30 (a01ecdb7e4b348d7fa71d576ae02f918b897a2df): 3.1s - T-29 (97992ee4384e445302377c0ee35281abc8079daf): 3.4s - T-28 (d70673a431723619961dd38778d72ccadc0b0f02): 1.5s - T-27 (cacee3f27337b6876f19648fb4f9101fdffc85fd): 2.7s - T-26 (52a665423de77ef569fa66a02d6291d12ede9667): 3.5s - T-25 (c0b0b7ad9608b0690581741d3dea644fde476dc6): 2.7s - T-24 (15399f431ee0a03a277a25b19ff4b42295ad3d2a): 2.7s - T-23 (ac5532d098d615efe03a55f9f8727523493ce4e2): 2.7s - T-22 (e4d0ba977cbdd88a20495b326bbaf0b1b401234a): 1.5s - T-21 (234379a3595fd8809d8bae0e4017570a3423cbb4): 1.5s - T-20 (5fc5321525756f5106509ded272b8f85e2d806e5): 1.5s - T-19 (fee5d2e190009b066d4d783090c76f9674dcb2b6): 1.5s - T-18 (b8a39b643d2c6101a20683e1a6823e1da188bf5a): 2.6s - T-17 (06ef08f4f96862917783227d488f2e5c9ddb81c5): 1.4s - T-16 (c0a64fc99bc49c9a43370a5056155fe17fbab3a4): 1.5s - T-15 (bcb0388489e28527fa14c0de957a8824c899e4dd): 1.5s - T-14 (5ca965f88059299af4e83bae9ab8583ebcb7ad1a): 1.4s - T-13 (46c96e2596f119885774c42840c8f7498736a55c): 1.5s - T-12 (145bc5fc20120dce597a5e3c5235144b6956cce5): 1.5s - T-11 (8ac5b33d75e003386a93dae3f6749d745c4028b8): 1.5s - T-10 (fd6c7e6a54d56dee8a0449834ec2fa3f8bb4e129): 1.4s - T-9 (1c7ce98f6924a1cad6d6ead04458ca19978ae991): 1.5s - T-8 (d40e8dd94d33d63061b41072e9023639b9d3e607): 1.4s - T-7 (dc6d7a5b706e4a60651931d67aa4544b8891bdab): 1.4s - T-6 (31faa09a45364754cc5309a503a8070b15314522): 1.4s - T-5 (0f23aa873989d0cad7dffd787efe0e5317891151): 1.4s - T-4 (e1511343c1436e3d9ae2003783c6341870059830): 1.4s - T-3 (f5fb309109408d25544fe34bdee77f917ff679e7): 1.4s - T-2 (cff89556fe722407240151e802ab0e2b28d741ac): 1.5s - T-1 (be424b244ccea5bfb20f65ba127a32c24d345f27): 1.5s - **T (current commit): 1.4s**

largeDepsNft: 5.4s

⬇️ 6.43% decrease vs. be424b244ccea5bfb20f65ba127a32c24d345f27

^                                                                                           5.8s          
│   5.5s    5.6s    5.5s    5.5s    5.6s    5.5s    5.5s    5.6s            5.4s    5.5s    ┌──┐    5.4s  
│ ──┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────5.4s────┌──┐────┌──┐────┼──┼────┌──┐──
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T
Legend - T-30 (a01ecdb7e4b348d7fa71d576ae02f918b897a2df): 9.8s - T-29 (97992ee4384e445302377c0ee35281abc8079daf): 10.8s - T-28 (d70673a431723619961dd38778d72ccadc0b0f02): 5.5s - T-27 (cacee3f27337b6876f19648fb4f9101fdffc85fd): 8.7s - T-26 (52a665423de77ef569fa66a02d6291d12ede9667): 11.1s - T-25 (c0b0b7ad9608b0690581741d3dea644fde476dc6): 8.5s - T-24 (15399f431ee0a03a277a25b19ff4b42295ad3d2a): 8.2s - T-23 (ac5532d098d615efe03a55f9f8727523493ce4e2): 8.5s - T-22 (e4d0ba977cbdd88a20495b326bbaf0b1b401234a): 5.5s - T-21 (234379a3595fd8809d8bae0e4017570a3423cbb4): 5.6s - T-20 (5fc5321525756f5106509ded272b8f85e2d806e5): 5.6s - T-19 (fee5d2e190009b066d4d783090c76f9674dcb2b6): 5.7s - T-18 (b8a39b643d2c6101a20683e1a6823e1da188bf5a): 8.1s - T-17 (06ef08f4f96862917783227d488f2e5c9ddb81c5): 5.5s - T-16 (c0a64fc99bc49c9a43370a5056155fe17fbab3a4): 5.6s - T-15 (bcb0388489e28527fa14c0de957a8824c899e4dd): 5.5s - T-14 (5ca965f88059299af4e83bae9ab8583ebcb7ad1a): 5.5s - T-13 (46c96e2596f119885774c42840c8f7498736a55c): 5.5s - T-12 (145bc5fc20120dce597a5e3c5235144b6956cce5): 5.5s - T-11 (8ac5b33d75e003386a93dae3f6749d745c4028b8): 5.6s - T-10 (fd6c7e6a54d56dee8a0449834ec2fa3f8bb4e129): 5.5s - T-9 (1c7ce98f6924a1cad6d6ead04458ca19978ae991): 5.5s - T-8 (d40e8dd94d33d63061b41072e9023639b9d3e607): 5.6s - T-7 (dc6d7a5b706e4a60651931d67aa4544b8891bdab): 5.5s - T-6 (31faa09a45364754cc5309a503a8070b15314522): 5.5s - T-5 (0f23aa873989d0cad7dffd787efe0e5317891151): 5.6s - T-4 (e1511343c1436e3d9ae2003783c6341870059830): 5.4s - T-3 (f5fb309109408d25544fe34bdee77f917ff679e7): 5.4s - T-2 (cff89556fe722407240151e802ab0e2b28d741ac): 5.5s - T-1 (be424b244ccea5bfb20f65ba127a32c24d345f27): 5.8s - **T (current commit): 5.4s**

largeDepsZisi: 10.3s

⬇️ 2.86% decrease vs. be424b244ccea5bfb20f65ba127a32c24d345f27

^  10.6s   10.5s   10.6s   10.4s   10.6s   10.4s   10.4s   10.4s           10.4s   10.5s   10.6s          
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐   10.3s    ┌──┐    ┌──┐    ┌──┐   10.3s  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T
Legend - T-30 (a01ecdb7e4b348d7fa71d576ae02f918b897a2df): 20s - T-29 (97992ee4384e445302377c0ee35281abc8079daf): 21.1s - T-28 (d70673a431723619961dd38778d72ccadc0b0f02): 10.4s - T-27 (cacee3f27337b6876f19648fb4f9101fdffc85fd): 17.2s - T-26 (52a665423de77ef569fa66a02d6291d12ede9667): 21.3s - T-25 (c0b0b7ad9608b0690581741d3dea644fde476dc6): 16.8s - T-24 (15399f431ee0a03a277a25b19ff4b42295ad3d2a): 16.5s - T-23 (ac5532d098d615efe03a55f9f8727523493ce4e2): 16.7s - T-22 (e4d0ba977cbdd88a20495b326bbaf0b1b401234a): 10.6s - T-21 (234379a3595fd8809d8bae0e4017570a3423cbb4): 10.6s - T-20 (5fc5321525756f5106509ded272b8f85e2d806e5): 10.6s - T-19 (fee5d2e190009b066d4d783090c76f9674dcb2b6): 10.5s - T-18 (b8a39b643d2c6101a20683e1a6823e1da188bf5a): 15.8s - T-17 (06ef08f4f96862917783227d488f2e5c9ddb81c5): 10.5s - T-16 (c0a64fc99bc49c9a43370a5056155fe17fbab3a4): 10.5s - T-15 (bcb0388489e28527fa14c0de957a8824c899e4dd): 10.5s - T-14 (5ca965f88059299af4e83bae9ab8583ebcb7ad1a): 10.5s - T-13 (46c96e2596f119885774c42840c8f7498736a55c): 10.4s - T-12 (145bc5fc20120dce597a5e3c5235144b6956cce5): 10.6s - T-11 (8ac5b33d75e003386a93dae3f6749d745c4028b8): 10.5s - T-10 (fd6c7e6a54d56dee8a0449834ec2fa3f8bb4e129): 10.6s - T-9 (1c7ce98f6924a1cad6d6ead04458ca19978ae991): 10.4s - T-8 (d40e8dd94d33d63061b41072e9023639b9d3e607): 10.6s - T-7 (dc6d7a5b706e4a60651931d67aa4544b8891bdab): 10.4s - T-6 (31faa09a45364754cc5309a503a8070b15314522): 10.4s - T-5 (0f23aa873989d0cad7dffd787efe0e5317891151): 10.4s - T-4 (e1511343c1436e3d9ae2003783c6341870059830): 10.3s - T-3 (f5fb309109408d25544fe34bdee77f917ff679e7): 10.4s - T-2 (cff89556fe722407240151e802ab0e2b28d741ac): 10.5s - T-1 (be424b244ccea5bfb20f65ba127a32c24d345f27): 10.6s - **T (current commit): 10.3s**