search

netlify / zip-it-and-ship-it

Intelligently prepare Node.js Lambda functions for deployment
https://www.npmjs.com/package/@netlify/zip-it-and-ship-it
MIT License
316 stars 35 forks source link

chore: reenable windows symlink test #1713

Closed Skn0tt closed 5 months ago

Skn0tt commented 6 months ago

Reenables a test that was skipped before, presumably because of a Github Actions detail that I know how to fix now!

github-actions[bot] commented 6 months ago

⏱ Benchmark results

Comparing with 1aefa6ece854070428a6c7ebfe85b183291920e9

largeDepsEsbuild: 1.3s

⬆️ 0.13% increase vs. 1aefa6ece854070428a6c7ebfe85b183291920e9

^           1.5s    1.5s    1.4s                                                                          
│   1.4s    ┌──┐    ┌──┐    ┌──┐                    1.4s                                                  
│   ┌──┐    |  |    |  |    |  |    1.3s    1.3s    ┌──┐    1.3s                    1.3s                  
│ ──┼──┼────┼──┼────┼──┼────┼──┼────┌──┐────┌──┐────┼──┼────┌──┐────1.3s────1.2s────┌──┐────1.3s────1.3s──
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    ┌──┐    ┌──┐    |  |    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T
Legend - T-30 (f01af04b8a3c84e3c91041f97de118d3f07aa580): 1.5s - T-29 (44f2871b631b6090272fd6a34e696f0d3ab95ed9): 1.4s - T-28 (a176e523e66a20e97f13a744d8d5985aca1ebccd): 1.5s - T-27 (897284e0dc37bb37e35974dd7e18a5e67715ae44): 1.5s - T-26 (30703f84b3f63ac0b382f17345c59b8e74c7d194): 1.5s - T-25 (ec7bde9885672878e3e002026ffe4bad9e9c1f8c): 1.4s - T-24 (05b3c1a2a10c04728884c62a027b005871202091): 1.4s - T-23 (393b4900bee89e74f91e05c8c0179bf3f145cb02): 1.5s - T-22 (abcba24aae5b32a9bbde85ba910d1b76913ad31d): 1.4s - T-21 (1b10dd153a662aa9ac658624ab017d4c474f2f90): 1.5s - T-20 (46377da9cc9534cca5836258deeff4e51168985b): 1.5s - T-19 (1a06dacedb7198e969dfcdd3c1081ccce6b6c5c5): 1.4s - T-18 (8a3845d6e1500eba8d07c1e29b1176d5c9ca7d85): 1.5s - T-17 (8ebae9d293d3ffb37e5f82a24e8e6ef1d59fe450): 1.4s - T-16 (655f1a8bb37176c719861ba16a3a3d69308ace2f): 1.5s - T-15 (64ee032943234b2a4def58ab53b00a2f7ee47742): 1.4s - T-14 (f129ca1266824706fe42385f7b20ccade73dfe3d): 1.4s - T-13 (bd3bd46b53aa8bdfaa6a144611f9fb360ceae31e): 1.5s - T-12 (136119a4ffdbce38734e454f6a3f06360974eef1): 1.4s - T-11 (9e82c5a761d0a00fe92cb8221f7e48756f46d06e): 1.5s - T-10 (db2f95984d77640e31e8006978822e134e91700e): 1.5s - T-9 (ee501c7c1f51ee3820b0f8da455854b1a57d05fa): 1.4s - T-8 (2c254891bc87f427c7b69501fafd3c4d18136711): 1.3s - T-7 (51f5e9e2056a13270a29390262c0e06ed5d34f98): 1.3s - T-6 (f947eb3e210c3332aa024c2989626b6d3ce9485f): 1.4s - T-5 (b06d5a278b9effee9a28f0eeb0e0e5f91d48b971): 1.3s - T-4 (06f408ee100ce0f86786598c36c271a60f114293): 1.3s - T-3 (8591222ba252c5747155c6d5165e92e48df51d63): 1.2s - T-2 (95285a7cc8fd8591d4872013fed1da6efcb18267): 1.3s - T-1 (1aefa6ece854070428a6c7ebfe85b183291920e9): 1.3s - **T (current commit): 1.3s**

largeDepsNft: 5.4s

⬇️ 4.00% decrease vs. 1aefa6ece854070428a6c7ebfe85b183291920e9

^                                                   5.8s                                    5.7s          
│   5.4s    5.6s    5.5s    5.5s    5.6s    5.6s    ┌──┐    5.5s            5.5s    5.5s    ┌──┐    5.4s  
│ ──┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┼──┼────┌──┐────5.3s────┌──┐────┌──┐────┼──┼────┌──┐──
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T
Legend - T-30 (f01af04b8a3c84e3c91041f97de118d3f07aa580): 5.5s - T-29 (44f2871b631b6090272fd6a34e696f0d3ab95ed9): 5.6s - T-28 (a176e523e66a20e97f13a744d8d5985aca1ebccd): 5.8s - T-27 (897284e0dc37bb37e35974dd7e18a5e67715ae44): 5.5s - T-26 (30703f84b3f63ac0b382f17345c59b8e74c7d194): 5.5s - T-25 (ec7bde9885672878e3e002026ffe4bad9e9c1f8c): 5.5s - T-24 (05b3c1a2a10c04728884c62a027b005871202091): 5.5s - T-23 (393b4900bee89e74f91e05c8c0179bf3f145cb02): 5.6s - T-22 (abcba24aae5b32a9bbde85ba910d1b76913ad31d): 5.5s - T-21 (1b10dd153a662aa9ac658624ab017d4c474f2f90): 5.8s - T-20 (46377da9cc9534cca5836258deeff4e51168985b): 5.8s - T-19 (1a06dacedb7198e969dfcdd3c1081ccce6b6c5c5): 5.6s - T-18 (8a3845d6e1500eba8d07c1e29b1176d5c9ca7d85): 5.3s - T-17 (8ebae9d293d3ffb37e5f82a24e8e6ef1d59fe450): 5.6s - T-16 (655f1a8bb37176c719861ba16a3a3d69308ace2f): 5.5s - T-15 (64ee032943234b2a4def58ab53b00a2f7ee47742): 5.7s - T-14 (f129ca1266824706fe42385f7b20ccade73dfe3d): 5.5s - T-13 (bd3bd46b53aa8bdfaa6a144611f9fb360ceae31e): 5.7s - T-12 (136119a4ffdbce38734e454f6a3f06360974eef1): 5.4s - T-11 (9e82c5a761d0a00fe92cb8221f7e48756f46d06e): 5.6s - T-10 (db2f95984d77640e31e8006978822e134e91700e): 5.5s - T-9 (ee501c7c1f51ee3820b0f8da455854b1a57d05fa): 5.5s - T-8 (2c254891bc87f427c7b69501fafd3c4d18136711): 5.6s - T-7 (51f5e9e2056a13270a29390262c0e06ed5d34f98): 5.6s - T-6 (f947eb3e210c3332aa024c2989626b6d3ce9485f): 5.8s - T-5 (b06d5a278b9effee9a28f0eeb0e0e5f91d48b971): 5.5s - T-4 (06f408ee100ce0f86786598c36c271a60f114293): 5.3s - T-3 (8591222ba252c5747155c6d5165e92e48df51d63): 5.5s - T-2 (95285a7cc8fd8591d4872013fed1da6efcb18267): 5.5s - T-1 (1aefa6ece854070428a6c7ebfe85b183291920e9): 5.7s - **T (current commit): 5.4s**

largeDepsZisi: 10.1s

⬇️ 3.80% decrease vs. 1aefa6ece854070428a6c7ebfe85b183291920e9

^          10.6s                   10.7s   10.7s   10.8s                                                  
│  10.2s    ┌──┐   10.3s   10.5s    ┌──┐    ┌──┐    ┌──┐   10.4s    10s    10.3s   10.4s   10.5s   10.1s  
│ ──┌──┐────┼──┼────┌──┐────┌──┐────┼──┼────┼──┼────┼──┼────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐──
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T
Legend - T-30 (f01af04b8a3c84e3c91041f97de118d3f07aa580): 10.4s - T-29 (44f2871b631b6090272fd6a34e696f0d3ab95ed9): 10.1s - T-28 (a176e523e66a20e97f13a744d8d5985aca1ebccd): 10.4s - T-27 (897284e0dc37bb37e35974dd7e18a5e67715ae44): 10s - T-26 (30703f84b3f63ac0b382f17345c59b8e74c7d194): 10.2s - T-25 (ec7bde9885672878e3e002026ffe4bad9e9c1f8c): 10.4s - T-24 (05b3c1a2a10c04728884c62a027b005871202091): 10.5s - T-23 (393b4900bee89e74f91e05c8c0179bf3f145cb02): 10.6s - T-22 (abcba24aae5b32a9bbde85ba910d1b76913ad31d): 10.1s - T-21 (1b10dd153a662aa9ac658624ab017d4c474f2f90): 10.7s - T-20 (46377da9cc9534cca5836258deeff4e51168985b): 10.6s - T-19 (1a06dacedb7198e969dfcdd3c1081ccce6b6c5c5): 10.5s - T-18 (8a3845d6e1500eba8d07c1e29b1176d5c9ca7d85): 10.5s - T-17 (8ebae9d293d3ffb37e5f82a24e8e6ef1d59fe450): 10.3s - T-16 (655f1a8bb37176c719861ba16a3a3d69308ace2f): 10.4s - T-15 (64ee032943234b2a4def58ab53b00a2f7ee47742): 10.6s - T-14 (f129ca1266824706fe42385f7b20ccade73dfe3d): 10.4s - T-13 (bd3bd46b53aa8bdfaa6a144611f9fb360ceae31e): 10.9s - T-12 (136119a4ffdbce38734e454f6a3f06360974eef1): 10.2s - T-11 (9e82c5a761d0a00fe92cb8221f7e48756f46d06e): 10.6s - T-10 (db2f95984d77640e31e8006978822e134e91700e): 10.3s - T-9 (ee501c7c1f51ee3820b0f8da455854b1a57d05fa): 10.5s - T-8 (2c254891bc87f427c7b69501fafd3c4d18136711): 10.7s - T-7 (51f5e9e2056a13270a29390262c0e06ed5d34f98): 10.7s - T-6 (f947eb3e210c3332aa024c2989626b6d3ce9485f): 10.8s - T-5 (b06d5a278b9effee9a28f0eeb0e0e5f91d48b971): 10.4s - T-4 (06f408ee100ce0f86786598c36c271a60f114293): 10s - T-3 (8591222ba252c5747155c6d5165e92e48df51d63): 10.3s - T-2 (95285a7cc8fd8591d4872013fed1da6efcb18267): 10.4s - T-1 (1aefa6ece854070428a6c7ebfe85b183291920e9): 10.5s - **T (current commit): 10.1s**
Skn0tt commented 6 months ago

The now-enabled test was passing on my Windows VM. I'm expecting it to fail in CI, because the tmpdir that's created is located on the C:/ drive, while the fixture is on the D:/ drive. Windows doesn't like copying/symlinking across drives, so i'm expecting this to fail now. If it does, the fix will be to place the tmp dir on the D:/ drive as well.

Skn0tt commented 6 months ago

Wait, it all passed? That doesn't match my theory, but I guess is still a good result.

Skn0tt commented 6 months ago

The other test is failing on Windows because of https://github.com/kevva/decompress/issues/41#issuecomment-1969067138.