feat: ship instrumentation file in functions bundle

lukasholzer commented 4 months ago

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes https://linear.app/netlify/issue/COM-455/build-console-span-exporter-for-the-new-runtime

Once https://github.com/netlify/serverless-functions-api/pull/221 is released we need to update this PR with the version and then we can ship the newly added ___netlify-telemetry.mjs file in each function bundle.

For us to review and ship your PR efficiently, please perform the following steps:

[ ] Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
[ ] Read the contribution guidelines 📖. This ensures your code follows our style guide and passes our tests.
[ ] Update or add tests (if any source code was changed or added) 🧪
[ ] Update or add documentation (if features were changed or added) 📝
[ ] Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

Skn0tt commented 4 months ago

and I think we should put this behind a flag.

github-actions[bot] commented 4 months ago

⏱ Benchmark results

Comparing with f8b965cd66038f653f1adca0ae9fcccfb4c85c7b

largeDepsEsbuild: 1.3s

⬆️ 1.69% increase vs. f8b965cd66038f653f1adca0ae9fcccfb4c85c7b

^   1.3s            1.3s            1.3s    1.3s            1.3s            1.3s            1.3s    1.3s  
│   ┌──┐    1.2s    ┌──┐    1.3s    ┌──┐    ┌──┐    1.3s    ┌──┐    1.3s    ┌──┐    1.2s    ┌──┐    ┌──┐  
│   |  |    ┌──┐    |  |    ┌──┐    |  |    |  |    ┌──┐    |  |    ┌──┐    |  |    ┌──┐    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

- T-30 (abcba24aae5b32a9bbde85ba910d1b76913ad31d): 1.4s - T-29 (1b10dd153a662aa9ac658624ab017d4c474f2f90): 1.5s - T-28 (46377da9cc9534cca5836258deeff4e51168985b): 1.5s - T-27 (1a06dacedb7198e969dfcdd3c1081ccce6b6c5c5): 1.4s - T-26 (8a3845d6e1500eba8d07c1e29b1176d5c9ca7d85): 1.5s - T-25 (8ebae9d293d3ffb37e5f82a24e8e6ef1d59fe450): 1.4s - T-24 (655f1a8bb37176c719861ba16a3a3d69308ace2f): 1.5s - T-23 (64ee032943234b2a4def58ab53b00a2f7ee47742): 1.4s - T-22 (f129ca1266824706fe42385f7b20ccade73dfe3d): 1.4s - T-21 (bd3bd46b53aa8bdfaa6a144611f9fb360ceae31e): 1.5s - T-20 (136119a4ffdbce38734e454f6a3f06360974eef1): 1.4s - T-19 (9e82c5a761d0a00fe92cb8221f7e48756f46d06e): 1.5s - T-18 (db2f95984d77640e31e8006978822e134e91700e): 1.5s - T-17 (ee501c7c1f51ee3820b0f8da455854b1a57d05fa): 1.4s - T-16 (2c254891bc87f427c7b69501fafd3c4d18136711): 1.3s - T-15 (51f5e9e2056a13270a29390262c0e06ed5d34f98): 1.3s - T-14 (f947eb3e210c3332aa024c2989626b6d3ce9485f): 1.4s - T-13 (b06d5a278b9effee9a28f0eeb0e0e5f91d48b971): 1.3s - T-12 (06f408ee100ce0f86786598c36c271a60f114293): 1.3s - T-11 (8591222ba252c5747155c6d5165e92e48df51d63): 1.2s - T-10 (95285a7cc8fd8591d4872013fed1da6efcb18267): 1.3s - T-9 (1aefa6ece854070428a6c7ebfe85b183291920e9): 1.3s - T-8 (7c7ce09b5fafebb0a9cf4246472ec27537eb02f8): 1.3s - T-7 (9e71c5b0e8cb870638168c05d1186b5fa92abcd4): 1.3s - T-6 (5b4140bb36d938bb2ed27254340dfee9e9f2e65e): 1.3s - T-5 (becb2ac0c7d7c8f07d114bbed21a559b7f335434): 1.3s - T-4 (a2071a6e606cc1434fa9d556306bd9dbc7cd7943): 1.3s - T-3 (66b668be6b42b2d0dcf3cfb4922b2c7c1023a6cc): 1.3s - T-2 (a789be6496f8df050b622f5c3597d63499419049): 1.2s - T-1 (f8b965cd66038f653f1adca0ae9fcccfb4c85c7b): 1.3s - **T (current commit): 1.3s**

largeDepsNft: 5.6s

⬆️ 1.06% increase vs. f8b965cd66038f653f1adca0ae9fcccfb4c85c7b

^                   5.5s    5.7s                                    5.6s                            5.6s  
│   5.3s    5.5s    ┌──┐    ┌──┐            5.3s    5.3s    5.5s    ┌──┐    5.3s    5.4s    5.5s    ┌──┐  
│ ──┌──┐────┌──┐────┼──┼────┼──┼────5.2s────┌──┐────┌──┐────┌──┐────┼──┼────┌──┐────┌──┐────┌──┐────|▒▒|──
│   |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

- T-30 (abcba24aae5b32a9bbde85ba910d1b76913ad31d): 5.5s - T-29 (1b10dd153a662aa9ac658624ab017d4c474f2f90): 5.8s - T-28 (46377da9cc9534cca5836258deeff4e51168985b): 5.8s - T-27 (1a06dacedb7198e969dfcdd3c1081ccce6b6c5c5): 5.6s - T-26 (8a3845d6e1500eba8d07c1e29b1176d5c9ca7d85): 5.3s - T-25 (8ebae9d293d3ffb37e5f82a24e8e6ef1d59fe450): 5.6s - T-24 (655f1a8bb37176c719861ba16a3a3d69308ace2f): 5.5s - T-23 (64ee032943234b2a4def58ab53b00a2f7ee47742): 5.7s - T-22 (f129ca1266824706fe42385f7b20ccade73dfe3d): 5.5s - T-21 (bd3bd46b53aa8bdfaa6a144611f9fb360ceae31e): 5.7s - T-20 (136119a4ffdbce38734e454f6a3f06360974eef1): 5.4s - T-19 (9e82c5a761d0a00fe92cb8221f7e48756f46d06e): 5.6s - T-18 (db2f95984d77640e31e8006978822e134e91700e): 5.5s - T-17 (ee501c7c1f51ee3820b0f8da455854b1a57d05fa): 5.5s - T-16 (2c254891bc87f427c7b69501fafd3c4d18136711): 5.6s - T-15 (51f5e9e2056a13270a29390262c0e06ed5d34f98): 5.6s - T-14 (f947eb3e210c3332aa024c2989626b6d3ce9485f): 5.8s - T-13 (b06d5a278b9effee9a28f0eeb0e0e5f91d48b971): 5.5s - T-12 (06f408ee100ce0f86786598c36c271a60f114293): 5.3s - T-11 (8591222ba252c5747155c6d5165e92e48df51d63): 5.5s - T-10 (95285a7cc8fd8591d4872013fed1da6efcb18267): 5.5s - T-9 (1aefa6ece854070428a6c7ebfe85b183291920e9): 5.7s - T-8 (7c7ce09b5fafebb0a9cf4246472ec27537eb02f8): 5.2s - T-7 (9e71c5b0e8cb870638168c05d1186b5fa92abcd4): 5.3s - T-6 (5b4140bb36d938bb2ed27254340dfee9e9f2e65e): 5.3s - T-5 (becb2ac0c7d7c8f07d114bbed21a559b7f335434): 5.5s - T-4 (a2071a6e606cc1434fa9d556306bd9dbc7cd7943): 5.6s - T-3 (66b668be6b42b2d0dcf3cfb4922b2c7c1023a6cc): 5.3s - T-2 (a789be6496f8df050b622f5c3597d63499419049): 5.4s - T-1 (f8b965cd66038f653f1adca0ae9fcccfb4c85c7b): 5.5s - **T (current commit): 5.6s**

largeDepsZisi: 10.4s

⬆️ 2.63% increase vs. f8b965cd66038f653f1adca0ae9fcccfb4c85c7b

^          10.3s   10.4s   10.5s                           10.3s   10.4s                           10.4s  
│   10s     ┌──┐    ┌──┐    ┌──┐   10.2s    10s     10s     ┌──┐    ┌──┐   10.2s   10.2s   10.2s    ┌──┐  
│ ──┌──┐────┼──┼────┼──┼────┼──┼────┌──┐────┌──┐────┌──┐────┼──┼────┼──┼────┌──┐────┌──┐────┌──┐────|▒▒|──
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

- T-30 (abcba24aae5b32a9bbde85ba910d1b76913ad31d): 10.1s - T-29 (1b10dd153a662aa9ac658624ab017d4c474f2f90): 10.7s - T-28 (46377da9cc9534cca5836258deeff4e51168985b): 10.6s - T-27 (1a06dacedb7198e969dfcdd3c1081ccce6b6c5c5): 10.5s - T-26 (8a3845d6e1500eba8d07c1e29b1176d5c9ca7d85): 10.5s - T-25 (8ebae9d293d3ffb37e5f82a24e8e6ef1d59fe450): 10.3s - T-24 (655f1a8bb37176c719861ba16a3a3d69308ace2f): 10.4s - T-23 (64ee032943234b2a4def58ab53b00a2f7ee47742): 10.6s - T-22 (f129ca1266824706fe42385f7b20ccade73dfe3d): 10.4s - T-21 (bd3bd46b53aa8bdfaa6a144611f9fb360ceae31e): 10.9s - T-20 (136119a4ffdbce38734e454f6a3f06360974eef1): 10.2s - T-19 (9e82c5a761d0a00fe92cb8221f7e48756f46d06e): 10.6s - T-18 (db2f95984d77640e31e8006978822e134e91700e): 10.3s - T-17 (ee501c7c1f51ee3820b0f8da455854b1a57d05fa): 10.5s - T-16 (2c254891bc87f427c7b69501fafd3c4d18136711): 10.7s - T-15 (51f5e9e2056a13270a29390262c0e06ed5d34f98): 10.7s - T-14 (f947eb3e210c3332aa024c2989626b6d3ce9485f): 10.8s - T-13 (b06d5a278b9effee9a28f0eeb0e0e5f91d48b971): 10.4s - T-12 (06f408ee100ce0f86786598c36c271a60f114293): 10s - T-11 (8591222ba252c5747155c6d5165e92e48df51d63): 10.3s - T-10 (95285a7cc8fd8591d4872013fed1da6efcb18267): 10.4s - T-9 (1aefa6ece854070428a6c7ebfe85b183291920e9): 10.5s - T-8 (7c7ce09b5fafebb0a9cf4246472ec27537eb02f8): 10.2s - T-7 (9e71c5b0e8cb870638168c05d1186b5fa92abcd4): 10s - T-6 (5b4140bb36d938bb2ed27254340dfee9e9f2e65e): 10s - T-5 (becb2ac0c7d7c8f07d114bbed21a559b7f335434): 10.3s - T-4 (a2071a6e606cc1434fa9d556306bd9dbc7cd7943): 10.4s - T-3 (66b668be6b42b2d0dcf3cfb4922b2c7c1023a6cc): 10.2s - T-2 (a789be6496f8df050b622f5c3597d63499419049): 10.2s - T-1 (f8b965cd66038f653f1adca0ae9fcccfb4c85c7b): 10.2s - **T (current commit): 10.4s**

lukasholzer commented 4 months ago

and I think we should put this behind a flag.

As this just adds a file to the bundle I don't think we need to add an additional flag to the whole sea of flags.

Skn0tt commented 4 months ago

I don't want to add another file to every single bundle a customer of ours creates, without an easy to way to roll this back. Let's please add a flag, just so that we can roll this back for individual customers where this might break things. Customers have the most weird setups ...

netlify / zip-it-and-ship-it