Call to static SimpleDateFormat - Githubissues

netmackan / ATimeTracker

Open Source Time Tracker for Android

GNU General Public License v2.0

120 stars 56 forks source link

Call to static SimpleDateFormat #109

Closed netmackan closed 5 years ago

netmackan commented 5 years ago

Code smells:

SimpleDateFormat is not thread safe
Weird initialization of date format from one class to static field of an other and duplicated in two places

Instead:

Move out the initialization from TimeRange and let the calling class handle that
Remove the initialization of static fields
For other cases: do not have static initialization of SimeDateFormat