search

netmanagers / puppet-varnish

[UNMAINTAINED] Puppet module to manage varnish
3 stars 9 forks source link

two variables used to define the name of the vcl file in use. #5

Closed benpriestman closed 11 years ago

benpriestman commented 11 years ago

In init.pp, we take two parameters relating to the name of the $vcl file: vcl_file and $vcl_template. $vcl_file is used to to define the path to actual file resource which is created but $vcl_conf is used in templates/varnish.erb to define the file read in at service start time. If you want to use a file name other than /etc/varnish/default.vcl, you need to specify both variables.

javierbertoli commented 11 years ago

Sorry for the delay in solving this, but I was trying to think of a way to fix it without needing to jump version for something that seems a 'minor bug'.

Removing the duplicated variable is backward incompatible for those who might have used it (me myself included), and I didn't want to bother people with this.

But in the end, I decided that it's better to correct it once and for all, left _$vclconf (I think it is the most intuitive variable name) and jump the major

SemVer of the module.

"Knowledge, sir, should be free to all!"
                             (Harry Mudd, "I, Mudd", stardate 4513.3)
benpriestman commented 11 years ago

Sounds good to me.

That's why I raised it as an issue, rather than just post it as a pull request.

Thanks for creating the module. I'm really keen on the whole example42 approach. There may be more bug reports/enhancements on the way!

Ben

On 01/10/2013 21:41, Javier Bértoli wrote:

Sorry for the delay in solving this, but I was trying to think of a way to fix it without needing to jump version for something that seems a 'minor bug'.

Removing the duplicated variable is backward incompatible for those who might have used it (me myself included), and I didn't want to bother people with this.

But in the end, I decided that it's better to correct it once and for all, left _$vclconf (I think it is the most intuitive variable name) and jump the major

SemVer of the module.

"Knowledge, sir, should be free to all!" (Harry Mudd, "I, Mudd", stardate 4513.3)

— Reply to this email directly or view it on GitHub https://github.com/netmanagers/puppet-varnish/issues/5#issuecomment-25487451.

javierbertoli commented 11 years ago

On 10/03/2013 06:52 PM, malaikah wrote:

Thanks for creating the module. I'm really keen on the whole example42 approach. There may be more bug reports/enhancements on the way!

You're welcome! Any help, suggestion, bug report or patch will be highly appreciated :)