netmelody / ci-eye

An infrastructure agnostic CI build radiator
http://netmelody.org/ci-eye/
Apache License 2.0
43 stars 26 forks source link

Does not work over https #5

Closed Grundlefleck closed 12 years ago

Grundlefleck commented 12 years ago

Hi scarytom,

I downloaded ci-eye v0.2.0 and when trying to access a Jenkins build server over https I get a stack trace like the one pasted below. Does seem to handle the error gracefully, as in, ci-eye remains active, presumably this means other views would still work - nice.

Admittedly https is unlikely to be required behind the firewall, but in my particular circumstances, I'm trying to access a hosted Jenkins cloud service. Is this likely to be something you'd consider including given such a minority use case? Happy to look into patching unless you have insider knowledge that makes it prohibitively difficult?

SEVERE: https://mutability-detector.ci.cloudbees.com/api/json
org.apache.http.client.ClientProtocolException
        at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:822)
        at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:941)
        at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:919)
        at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:910)
        at org.netmelody.cieye.server.observation.protocol.RestRequester.makeRequest(RestRequester.java:65)
        at org.netmelody.cieye.server.observation.protocol.JsonRestRequester.makeJsonRestCall(JsonRestRequester.java:39)
        at org.netmelody.cieye.spies.jenkins.JenkinsCommunicator.makeJenkinsRestCall(JenkinsCommunicator.java:67)
        at org.netmelody.cieye.spies.jenkins.JenkinsCommunicator.makeJenkinsRestCallWithSuffix(JenkinsCommunicator.java:62)
        at org.netmelody.cieye.spies.jenkins.JenkinsCommunicator.views(JenkinsCommunicator.java:58)
        at org.netmelody.cieye.spies.jenkins.JenkinsSpy.jobsFor(JenkinsSpy.java:89)
        at org.netmelody.cieye.spies.jenkins.JenkinsSpy.targetsConstituting(JenkinsSpy.java:44)
        at org.netmelody.cieye.server.observation.PollingSpy.update(PollingSpy.java:94)
        at org.netmelody.cieye.server.observation.PollingSpy.access$100(PollingSpy.java:34)
        at org.netmelody.cieye.server.observation.PollingSpy$StatusUpdater.run(PollingSpy.java:153)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
    at java.util.concurrent.FutureTask$Sync.innerRunAndReset(FutureTask.java:351)
    at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:178)
    at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:178)
    at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
    at java.lang.Thread.run(Thread.java:722)

Caused by: org.apache.http.HttpException: Scheme 'https' not registered. at org.apache.http.impl.conn.DefaultHttpRoutePlanner.determineRoute(DefaultHttpRoutePlanner.java:115) at org.apache.http.impl.client.DefaultRequestDirector.determineRoute(DefaultRequestDirector.java:721) at org.apache.http.impl.client.DefaultRequestDirector.execute(DefaultRequestDirector.java:358) at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:820) ... 21 more

scarytom commented 12 years ago

give me 10 and I'll have a fix for this

scarytom commented 12 years ago

Fix pushed on master. I'll do a release tomorrow when I'm more awake.