netmindz / balboa_GL_ML_spa_control

Control protocol between GL2000 controller and ML series compatibile top panel
16 stars 8 forks source link

Set target temp buggy #31

Closed netmindz closed 7 months ago

netmindz commented 1 year ago

Sometimes you can use the climate HA entry to set the target correctly, sometimes it will change, but misses or duplicates temp+ or temp- actions. You do however see the real target temp in HA so you can try to change again if your first attempt doesn't work as planned

netmindz commented 11 months ago

How is your experience of setting the temp with your version of the code that only sends the command once @tmjo ?

tmjo commented 11 months ago

I think it was working alright, just that I have to "manually" update my target setpoint by giving it a up or down (with appropriate delays) to ensure it has the correct target temp. I'll doublecheck to see.

tmjo commented 11 months ago

I did a lot of testing today, and found out it was not working very well when trying larger steps in temperature. I added a lot of empty command paddings and then it was working fine. Same goes for most of the other commands. Better late than never, I uploaded my adjustments to a new branch (main-fork-tmjo just for info where only the last commit is interesting (the others are temporary stuff I have to do to run it).

It took me some time, because somehow I lost most of my adjustments in a company ordered reboot so I had to do it all over and then make sure it works. But this works perfectly on my tub at least :)

Perhaps we could add a generic empty-padding thing instead of adding them all around?

netmindz commented 8 months ago

I've tweaked the code so that there is a pause between sending commands to better match how a human would be pressing buttons and it's seeming much improved .

Are you able to test how main or the latest release tag works for you @tmjo ?

tmjo commented 8 months ago

Sure thing, I'll test it out. Can't promise exactly when, it's busy days (and cold+dark outside 😎) but I'll get to it for sure!

netmindz commented 8 months ago

Can do webOTA in the newer releases so can do some of the work from the comfort of indoors and test with your phone when inside the tub

tmjo commented 8 months ago

Yeah, I'm mostly doing OTAs but it has failed me one too many times sending me out to physically reboot the ESP. But testing comfortably inside the tub is pretty nice though :)

netmindz commented 7 months ago

Set temp now working correctly with the pause between commands