search

netmix / radio-station

Radio Station WordPress Plugin (Open Source)
https://netmix.com
GNU General Public License v3.0
20 stars 14 forks source link

Import schedule interprets 12:30 as 12:30 am instead of 12:30 pm #442

Open montereyjeff opened 1 year ago

montereyjeff commented 1 year ago

After importing this YAML content:

The schedule showed the time range as 12:30 am to 1:00 pm instead of 12:30 pm to 1:00 pm.

tonyzeoli commented 1 year ago

Thanks for reporting this. An external developer created this feature and I'll have to contact him to ask him to fix this issue. We'll let you know when it can be resolved.

tonyzeoli commented 1 year ago

@voyager131 if you have some time to look at this and update the code, that would be helpful. Thanks.

montereyjeff commented 1 year ago

I did some further testing. Using these times:

which showed up this way in the schedule column of the list of shows: Saturday :30am - 1:00am

but when I open the show itself and look at the Show Schedule, it says 1:30 am to 1:00 am.

The 00 hour should be 12 am and the 12 hour (in 24-hour format) should be 12 pm.

montereyjeff commented 1 year ago

And still more testing...

  1. If the "Delete existing show data" box is checked on import, this warning appears: Warning: _() expects exactly 1 parameter, 2 given in /home/customer/www/kspb.org/public_html/wp-content/plugins/radio-station-pro-premium/includes/rsp-import-export.php on line 1330

  2. The import interpreted 10:00 (in 24-hour format) as 1:00 am

  3. Can you add export and import support for show-genre?

  4. Empty images are created in the site Media Library when a show does not have every possible image file. For example, if a show has a show-avatar but not a show-image or show-header, then two empty image files with random names are added to the Media Library in addition to the avatar image file.

tonyzeoli commented 1 year ago

Okay, let's get this to Tony Hayes and Andrew who wrote the YML feature and see if we can't get this fixed asap.

On Mon, Mar 13, 2023 at 4:32 PM montereyjeff @.***> wrote:

I did some further testing. Using these times:

  • show-title: 'The Cultural Frontline' show-schedule: { Saturday: [['00:30', '01:00']] } show-active: 'on'

which showed up this way in the schedule column of the list of shows: Saturday :30am - 1:00am

but when I open the show itself and look at the Show Schedule, it says 1:30 am to 1:00 am.

The 00 hour should be 12 am and the 12 hour (in 24-hour format) should be 12 pm.

— Reply to this email directly, view it on GitHub https://github.com/netmix/radio-station/issues/442#issuecomment-1466915957, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA65WOZKUAFCBQUW7VPPMK3W3577RANCNFSM6AAAAAAVW6ECCE . You are receiving this because you commented.Message ID: @.***>