search

netmod-wg / yang-ver-dt

Repo for use by the YANG versioning design team
3 stars 3 forks source link

Do we need to callout "unchanged" #16

Open xorrkaz opened 5 years ago

xorrkaz commented 5 years ago

I don't like the idea of "unchanged". It's only defined and never used in the draft. I think "unchanged" is the same as editorial for all intents and purposes. I think whitespace changes are editorial, and I don't see the value of calling these out separately from editorial.

I propose we remove its definition from the draft. Rob asserts that a module may increase version with zero changes. This would differ from what the draft currently says about unchanged, and still I don't think we need to call this out.

rgwilton commented 5 years ago

I don't like the idea of "unchanged". It's only defined and never used in the draft. I think "unchanged" is the same as editorial for all intents and purposes. I think whitespace changes are editorial, and I don't see the value of calling these out separately from editorial.

I propose we remove its definition from the draft. Rob asserts that a module may increase version with zero changes. This would differ from what the draft currently says about unchanged, and still I don't think we need to call this out. I'm not saying this, this isn't allowed. But it is the case that two versions might be identical apart from their version history. E.g. 1.0.1M introduced some NBC change. 1.0.2M decides that was a mistake and backs it out again. The content in 1.0.2M is identical to 1.0.0, except for the version/revision history.

If tooling compares 1.0.0 and 1.0.2M I think that it is most useful to report these as "unchanged" rather than "editorial".

So, I think that the definition of "unchanged" is likely to be useful, but possibly could be deferred to the version comparison draft. But conversely, it might be useful in other cases. E.g. is it best to keep the entire definition of YANG semantic versioning in only one place.

sunseawq commented 5 years ago

Is version comparison draft referred to draft-wang-netmod-module-revision-management-01?

xorrkaz commented 1 year ago

This issue is currently moot as draft-ietf-netmod-yang-schema-comparison (in this repo) no longer mentions "unchanged". That said, if pyang is to be the reference tool, when it compares two module revisions, if they are backwards compatible, it doesn't produce any output.