search

netneurolab / netneurotools

Useful tools from the Network Neuroscience Lab
https://netneurolab.github.io/netneurotools
BSD 3-Clause "New" or "Revised" License
60 stars 32 forks source link

Added plot_fslr() function and a yerkes19 fetcher #103

Closed VinceBaz closed 3 years ago

VinceBaz commented 3 years ago

I added a plot_fslr() function, which basically is a generalization of the plot_conte69() function. This function asks the user which surface atlases he wants to use. For human brains, this atlas will more often than not be the conte69 atlas. For macaque, however, other atlases exist. One of these atlases is the Yerkes19 atlas (Donahue et al., 2016, J. Neurosci.).

I also added a fetcher function: fetch_yerkes19() to download this Yerkes19 atlas.

codecov-commenter commented 3 years ago

Codecov Report

Merging #103 (2202b33) into master (79936ea) will decrease coverage by 1.12%. The diff coverage is 70.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage   73.17%   72.05%   -1.13%     
==========================================
  Files          26       26              
  Lines        1838     1893      +55     
==========================================
+ Hits         1345     1364      +19     
- Misses        493      529      +36
Impacted Files Coverage Δ
netneurotools/datasets/__init__.py 100.00% <ø> (ø)
netneurotools/plotting.py 65.54% <22.22%> (-0.87%) :arrow_down:
netneurotools/datasets/fetchers.py 89.90% <100.00%> (+0.61%) :arrow_up:
netneurotools/tests/test_datasets.py 98.93% <100.00%> (+0.03%) :arrow_up:
netneurotools/metrics.py 35.84% <0.00%> (-53.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 79936ea...2202b33. Read the comment docs.

VinceBaz commented 3 years ago

Actually, I also found a bug in the plot_fsaverage() function, which is from when we added the plot_fsvertex() function: basically, in plot_fsaverage(), we reorder the data so that it is 'lr'. So when we call plot_fsvertex(), we should always have order=='lr'.

Since I was working on the plotting.py files, I thought I might as well fix it in this pull request.

rmarkello commented 3 years ago

Nice catch!! Thanks so much for doing this. Looks good to me so I'm gonna go ahead and merge :raised_hands: