search

netneurolab / netneurotools

Useful tools from the Network Neuroscience Lab
https://netneurolab.github.io/netneurotools
BSD 3-Clause "New" or "Revised" License
57 stars 33 forks source link

[FIX] GH Actions #107

Closed liuzhenqi77 closed 3 years ago

codecov-commenter commented 3 years ago

Codecov Report

Merging #107 (be8ae3d) into master (fbdf9a3) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   72.00%   72.00%           
=======================================
  Files          26       26           
  Lines        1897     1897           
=======================================
  Hits         1366     1366           
  Misses        531      531

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fbdf9a3...be8ae3d. Read the comment docs.

liuzhenqi77 commented 3 years ago

Seems caused by this very new issue enthought/mayavi/issues/1057 Fixing vtk==9.0.1 in install_dependencies.sh makes the check work We could fix it temporarily or ignore this check and wait for their update. 🤷‍♂️

rmarkello commented 3 years ago

I'm fine for this temporary fix since there's no current timeline on when that'll be resolved! We can monitor it and unpin vtk once it's addressed.

rmarkello commented 3 years ago

(But brilliant detective work! :detective: Thank you so much :raised_hands:)