search

netneurolab / netneurotools

Useful tools from the Network Neuroscience Lab
https://netneurolab.github.io/netneurotools
BSD 3-Clause "New" or "Revised" License
57 stars 33 forks source link

Add dominance analysis function #96

Closed liuzhenqi77 closed 3 years ago

liuzhenqi77 commented 3 years ago

I have an example script here to get some dominance analysis stats. It's faster than the original package, but can still be further optimized / parallelized. Since we are using it more, maybe we could discuss what extra features we need and integrate it into netneurotools.

rmarkello commented 3 years ago

Yes, definitely! This would be a perfect fit for netneurotools.stats I think :grin: The gist you've linked to would be great as a PR—no need to do any further optimizing for now. The only note I have right now is that we don't currently require tqdm, but it's such a lightweight dependency you're welcome to add it (or you can remove the calls from your function, if you'd prefer not to 🤷‍♂️).

Ping me once you've got a PR open and I'll do a quick pass!