liuzhenqi77 commented 3 years ago

I also added some notes for fsaverage plotting. Btw, do we have a solution (other than re-installing graphics card drivers 🤯) for the surface mosaics?

codecov-commenter commented 3 years ago

Codecov Report

Merging #98 (f771a6d) into master (79936ea) will not change coverage. The diff coverage is n/a.

:exclamation: Current head f771a6d differs from pull request most recent head 7bd92e7. Consider uploading reports for the commit 7bd92e7 to get more accurate results

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   73.17%   73.17%           
=======================================
  Files          26       26           
  Lines        1838     1838           
=======================================
  Hits         1345     1345           
  Misses        493      493

Impacted Files	Coverage Δ
netneurotools/plotting.py	`66.41% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 79936ea...7bd92e7. Read the comment docs.

liuzhenqi77 commented 3 years ago

haha it's super okay no worries about the delay! I was just putting them here just as my notes at the time. Thank you so much for the review!

liuzhenqi77 commented 3 years ago

seems need to add # doctest: +ELLIPSIS for the line with downloading (?) but i don't know how to nicely break the long lines to follow width limit. 🤦‍♂️

rmarkello commented 3 years ago

Let's try this :crossed_fingers: Hopefully this should suppress and output from the fetchers...

liuzhenqi77 commented 3 years ago

ahhh nice save! Thank you Ross!

rmarkello commented 3 years ago

Woohoo! Looks like it all passed. Merging now!! Thank you again @liuzhenqi77 :pray: :raised_hands:

netneurolab / netneurotools

[DOC] Added example for plotting on fsaverage surface #98

Codecov Report