Bug in all parcellation-specific null models

netneurolab / neuromaps

A toolbox for comparing brain maps

https://netneurolab.github.io/neuromaps

Other

241 stars 55 forks source link

Bug in all parcellation-specific null models #3

Open rmarkello opened 3 years ago

rmarkello commented 3 years ago

The following line is present in all parcellation-specific null models (i.e., nulls.vasa, nulls.hungarian, nulls.baum, and nulls.cornblath):

https://github.com/netneurolab/brainnotation/blob/09ef3c88270f85d97de83d69e51cb6917e21f417/brainnotation/nulls/nulls.py#L190

But it should be the opposite (i.e., if parcellation is None). Currently all of these functions are useless :grimacing: Should be an easy fix, though!

(h/t to @danjgale for pointing this out)

rmarkello commented 3 years ago

Hypothetically fixed with the mess of a PR that was #5. Gonna leave this open 'till I add some tests to confirm, though.