Closed jotak closed 2 years ago
cc @KalmanMeth @ronensc @eranra
I thought we had an issue for this, but I can't find it
I thought we had an issue for this, but I can't find it
Ah, maybe this: https://github.com/netobserv/flowlogs-pipeline/issues/197
@jotak we thought to use camelCase
like in k8s. WDYT? do you have any preference?
@jotak we thought to use
camelCase
like in k8s. WDYT? do you have any preference?
+1, it sounds more natural to me too
Summary of renamings:
prom.metrics.valuekey => prom.metrics.valueKey
prom.expirytime => prom.expiryTime
kafka.addr => kafka.address
kafka.groupbalancers => kafka.groupBalancers
kafka.startoffset => kafka.startOffset
kafka.batchreadtimeout => kafka.batchReadTimeout
grpc.buffer_length => grpc.bufferLength
network.kubeconfigpath => network.kubeConfigPath
network.servicesfile => network.servicesFile
network.protocolsfile => network.protocolsFile
aggregates.Name => aggregates.name
aggregates.By => aggregates.by
aggregates.Operation => aggregates.operation
aggregates.RecordKey => aggregates.recordKey
aggregates.TopK => aggregates.topK
closed by #213
The api is not fully consistent, some names are
camelCase
, otherlowcase
and sometimessnake_case
, e.g:valuekey
expirytime
readTimeout
batchSize
buffer_length
We should agree on a convention to follow