Check if we can remove the `_Evaluate` from the add_if operation - Githubissues

netobserv / flowlogs-pipeline

Transform flow logs into metrics

Apache License 2.0

69 stars 21 forks source link

Check if we can remove the `_Evaluate` from the add_if operation #23

Open eranra opened 2 years ago

ronensc commented 2 years ago

The relevant code is here: https://github.com/netobserv/flowlogs-pipeline/blob/9e8e6f551a4e9578b4f6afe5262b45518946eebf/pkg/pipeline/transform/transform_network.go#L95

Other operations also add fields with various suffixes:

AddRegExIf adds a _Matched field https://github.com/netobserv/flowlogs-pipeline/blob/9e8e6f551a4e9578b4f6afe5262b45518946eebf/pkg/pipeline/transform/transform_network.go#L83
AddLocation adds _CountryName, _CountryLongName, _RegionName, _CityName, _Latitude, _Longitude fields https://github.com/netobserv/flowlogs-pipeline/blob/9e8e6f551a4e9578b4f6afe5262b45518946eebf/pkg/pipeline/transform/transform_network.go#L111-L116
AddKubernetes adds _Namespace,_Name,_Type,_OwnerName,_OwnerType fields https://github.com/netobserv/flowlogs-pipeline/blob/9e8e6f551a4e9578b4f6afe5262b45518946eebf/pkg/pipeline/transform/transform_network.go#L145-L149

So what is the specific problem with _Evaluate?